Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null pointer in ITestRunner.runFixtures() #89

Open
RealyUniqueName opened this issue May 14, 2019 · 3 comments · Fixed by #91
Open

Null pointer in ITestRunner.runFixtures() #89

RealyUniqueName opened this issue May 14, 2019 · 3 comments · Fixed by #91

Comments

@RealyUniqueName
Copy link
Member

See https://ci.appveyor.com/project/HaxeFoundation/haxe/builds/24528515/job/358qtede8on630nl#L656
This is probably related to #82

@Aurel300
Copy link
Contributor

Ok, I reproduced the issue locally. The problem occurs when teardownClass throws an error. It is caught here:

utest/src/utest/Runner.hx

Lines 398 to 406 in c35845e

try {
teardownAsync = teardownClass();
} catch(e:Dynamic) {
teardownFailed(TeardownError('tearDownClass failed: $e', CallStack.exceptionStack()));
}
//case was executed synchronously from `runCases()`
if(teardownAsync.resolved && finishedHandler == null) {
return true;
}

teardownFailed then dispatches the result, but the function then continues. There should probably be a return true; after the call to teardownFailed.

@RealyUniqueName
Copy link
Member Author

Thanks!

Aurel300 added a commit to Aurel300/utest that referenced this issue May 15, 2019
RealyUniqueName pushed a commit that referenced this issue May 15, 2019
@RealyUniqueName
Copy link
Member Author

Leaving this open to not forget to add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants