Add support for deriving ToExpr from Show - #94
Closed
Gabriella439 wants to merge 1 commit into
Closed
Gabriella439 wants to merge 1 commit into
Gabriella439 wants to merge 1 commit into
Conversation
I didn't really change the `ToExpr` class, but this adds two useful functions that allow one to implement a `ToExpr` instance if a type already has a `Show` instance.
phadej
reviewed
Aug 31, 2024
| -} | ||
| showToExpr :: Show a => a -> Either ShowParseFailed Expr | ||
| showToExpr a = | ||
| case Parsec.parse exprParser "" (show a) of |
Collaborator
There was a problem hiding this comment.
This doesn't work. exprParser is not parser for Haskell expressions. Close syntax, but not the same.
EDIT: In particular infix operators are something which is not accepted by exprParser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't really change the
ToExprclass, but this adds two useful functions that allow one to implement aToExprinstance if a type already has aShowinstance.