Skip to content

Commit e501edc

Browse files
Bump vscode-languageclient from 7.0.0 to 8.1.0 (#857)
* Bump vscode-languageclient from 7.0.0 to 8.1.0 Bumps [vscode-languageclient](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client) from 7.0.0 to 8.1.0. - [Release notes](https://github.com/Microsoft/vscode-languageserver-node/releases) - [Commits](https://github.com/Microsoft/vscode-languageserver-node/commits/HEAD/client) --- updated-dependencies: - dependency-name: vscode-languageclient dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Fix error type of asyncCallback * Remove TransportKind from server arguments VSCode LanguageClient 8.1.0 adds cli parameters if the TransportKind is given. However, we do not want any extra cli parameters at the moment. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Fendor <[email protected]>
1 parent e20584e commit e501edc

File tree

4 files changed

+408
-394
lines changed

4 files changed

+408
-394
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@
583583
],
584584
"dependencies": {
585585
"ts-pattern": "^4.2.2",
586-
"vscode-languageclient": "^7.0.0",
586+
"vscode-languageclient": "^8.1.0",
587587
"which": "^3.0.1"
588588
}
589589
}

src/extension.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import {
1717
Logger,
1818
RevealOutputChannelOn,
1919
ServerOptions,
20-
TransportKind,
2120
} from 'vscode-languageclient/node';
2221
import { RestartServerCommandName, StartServerCommandName, StopServerCommandName } from './commands/constants';
2322
import * as DocsBrowser from './docsBrowser';
@@ -236,8 +235,8 @@ async function activateServerForFolder(context: ExtensionContext, uri: Uri, fold
236235
// For our intents and purposes, the server should be launched the same way in
237236
// both debug and run mode.
238237
const serverOptions: ServerOptions = {
239-
run: { command: serverExecutable, transport: TransportKind.stdio, args, options: exeOptions },
240-
debug: { command: serverExecutable, transport: TransportKind.stdio, args, options: exeOptions },
238+
run: { command: serverExecutable, args, options: exeOptions },
239+
debug: { command: serverExecutable, args, options: exeOptions },
241240
};
242241

243242
logger.info(`run command: ${serverExecutable} ${args.join(' ')}`);

src/hlsBinaries.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import * as child_process from 'child_process';
2-
import { ExecException } from 'child_process';
32
import * as fs from 'fs';
43
import { stat } from 'fs/promises';
54
import * as https from 'https';
@@ -34,7 +33,7 @@ const exeExt = process.platform === 'win32' ? '.exe' : '';
3433
* Callback invoked on process termination.
3534
*/
3635
type ProcessCallback = (
37-
error: ExecException | null,
36+
error: child_process.ExecFileException | null,
3837
stdout: string,
3938
stderr: string,
4039
resolve: (value: string | PromiseLike<string>) => void,

0 commit comments

Comments
 (0)