Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout case bug #247

Open
thumphries opened this issue May 4, 2017 · 4 comments
Open

Layout case bug #247

thumphries opened this issue May 4, 2017 · 4 comments
Labels

Comments

@thumphries
Copy link
Contributor

          { case v.minus of
              True ->
                {|<span class="{{ bikeshed/modules/general/number/size-class size }}--unit">-</span>|}
              False ->
                {{ "" }}
          }{ case typ of
              NumberDollar ->
                {|<span class="{{ bikeshed/modules/general/number/size-class size }}--unit">$</span>|}
              otherwise ->
                {{ "" }}
          }{{ v.value }}

errant WhiteSpace node appears after HTML cases

can work around with parentheses for now, but this is likely a bug in Layout.hs

@thumphries thumphries added the bug label May 4, 2017
@thumphries
Copy link
Contributor Author

case x of
  True ->
    <a/>
  False ->
    {blank}

@thumphries
Copy link
Contributor Author

Bug is here as wnl z ws : wsf ws w

basically we're handling the whitespace before we figure out whether or not it's used to close a scope, which is wrong. should probably make that decision in newline or somewhere else. hard problem.

can't quite comment it right out as it would kill more whitespace than a user would ever expect

@thumphries
Copy link
Contributor Author

Thought about this a little more and I think you could probably push the wnl wsf code directly into newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant