Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control characters cause log lines to not be sent as separate events #31

Open
nhibberd opened this issue Jan 27, 2017 · 1 comment
Open

Comments

@nhibberd
Copy link
Member

Completed 108 of 118 part(s) with 10 file(s) remaining
2017-01-27 02:40:40download: s3://... to ..

@charleso
Copy link
Contributor

Some more information.

fsPut :: FileSyncer -> ByteString -> IO () is basically assuming that each ByteString ends in \n. This is mostly true given how it's consumed at the moment by handles that buffer, but not guaranteed.

Suggested fix:

  1. Expose a Conduit function that:
  • Replaces the relevant \r and other control characters to \n
  • Call lines
  1. Deprecate fsPut and add fsPutLn which appends a \n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants