Each not pushing on a context level

[charleso]

{{#each foo}}
  {{#each bar}}
    {{../title}}
  {{/each}}
{{/each}

../title will blow up, but title works fine

[damncabbage]

Uh, this is missing some context. Can you state the inputs to this template?

Edit: I'm assuming a structure like:

{
  "foo": [
    { "title": "hi", "bar": [{ "ignored": true }] }
  ]
}

[damncabbage]

AFAICT it's missing a withContext that would change the scope. I can't even get your example to run (to reach the ../title error) without doing this instead:

{{#each foo as |f| }}
  {{#each f.bar as |b| }}
    {{ f.title }}
    {{ ../title }}
  {{/each}}
{{/each}}

Note! My example above works on tryhandlebars. Yes, that's right: it's scoped (../title), but not really (f; ../f doesn't work, FYI). Goddamnit.

[damncabbage]

Shorter failing case we can't currently work around AFAIK (because a workaround for BMX would break Handlebars version, and vice-versa):

{{ title }}
{{#each foo }}
  {{ ../title }}
{{/each}}

{
  "title": "hi",
  "foo": [{}]
}

[charleso]

Shorter failing case we can't currently work around AFAIK

Yeah, sorry your last test case is actually the one I hit (so couldn't even assign a name to the other context). Thanks for filling in more details.

[thumphries]

I don't follow, why would each push a new context? all it does is define 'this' and some data variables

What does handlebars do?

[thumphries]

AFAICT it's missing a withContext

yep you can just wrap it in withContext and it should do what you want

[damncabbage]

What does handlebars do?

each in Handlebars pushes a new context. BUT, for some reason, I can also see the named params, as if they were in the same scope. It makes no damn sense.

Take this example that I tried on tryhandlebars:

{{#each foo as |f| }}
  {{#each f.bar as |b| }}
    {{#each b.quux as |c| }}
      -{{ f.title }}-      {{!-- ../../f.title doesn't work --}}
      ={{ ../../title }}=  {{!-- title doesn't work, neither does ../title --}}
    {{/each}}
  {{/each}}
{{/each}}

{ "foo": [
    {
      "title": "hi",
      "bar": [
        { "quux": [{}] }
      ]
    }
]}

[markhibberd]

So I think an even simpler case that I just hit was:

{
  foo: [{"bar": "bar", "baz":"baz"}]
}

{{#each foo}}
  {{bar}}
  {{baz}}
{{/each}}

[damncabbage]

That's definitely a simple way to demonstrate the not-pushing-a-scope-ness. The real kicker about this bug is that we're damned if we push a scope (an as |x|'s x variable will be in the wrong scope) and damned if we don't (the ../'d and implicit-this [your example] references don't work).

[markhibberd]

@damncabbage Interestingly I use an explicit this successfully in a non-bikeshed context, just using bmx https://github.com/ambiata/boris/blob/master/boris-http/template/builds.hbs#L32-L36 I am kind of surprised that works when others fail.

[thumphries]

Just confirming what y'all have probably figured out by now:

The current implementation of each only sets this, @first, @last, @index, @key. Doesn't do anything else. so in the example above I'd expect this to be used:

{{each foo}}
  {{this.bar}}
  {{this.baz}}
{{/each}}

This is a mistake, a bug for sure. Anything that gets rid of this or .. in everyday use is an improvement.

I think we should stick to a definition that keeps us mustache-compliant, i.e. fix the JS block parameter scoping insanity and then make BMX push a context.