Partial Block and Passing Scope

[damncabbage]

test.json:

{ "donut": { "title": "Hello!" } }

test.hbs:

{{#*inline "donut"}}
<h1>{{> @partial-block }}</h1>
{{/inline}}

{{#>donut}}
  {{~ donut.title ~}}
{{/donut}}

{{#>donut donut}}
  {{~ title ~}}
{{/donut}}

$ cat test.hbs | dist/build/BMX/bmx -c test.json
Rendering error at line 10, col 7:
  Invoked value 'title' is not defined

This works with Handlebars.js (locally and tryhandlebarsjs.com both produce: <h1>Hello!</h1>\n\n<h1>Hello!</h1>), but doesn't work with BMX. 😰

Handlebars.js' behaviour, as I was explaining earlier to @russmaxdesign and @charleso, does not match my mental model of how the hell this is meant to work. Whether we choose to support this + "fix" the BMX implementation, or disallow this behaviour entirely, is up for discussion I think.

[damncabbage]

ps: sorry

[thumphries]

The implementation of partial blocks is a total hack, I just evaluate it in the outer (calling) scope and inline the result. i.e. {{> @partial-block donut }} is intentionally broken.

I don't think this case makes sense, though? Aren't partial blocks always meant to be evaluated in the outer scope, and the argument is just for the partial itself?

[damncabbage]

Posting this upstream: handlebars-lang/handlebars.js#1226

In the mean time, we'll avoid use of this scope-object-passing thing.