Work card images #13
Open
Work card images #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I just want to add thumbnail. Not the modal. Can you remove the code you have added for modal? including react-bootstrap? |
Not finished yet, still need to add masonry layout
|
I still need to fix the grid layout. Not ready yet. |
|
Should be cleaned up, and ready to pull now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully a better formatted pull request. I added images to work-cards that toggles on if the user has entered them in the config. It does require more configuration to enable vs the default one. I added one package to create this feature, react-bootstrap. For an example of a config you can checkout the dormguide card section in my fork. But basically the format would be:
images: [
dormguide1.src,
dormguide2.src,
dormguide3.src,
dormguide4.src,
dormguide5.src,
dormguide6.src,
],
It does require a little more manual import than the original.
One minor bug is that image cards can be significantly taller (does have a max-height) than text only cards and cause the whole row to be taller. Looks best if images on a separate row.
Preview: wesleydavenport.dev