fixing did-update on disclosure-primitive

Author: zamoore

packages/components/src/components/hds/disclosure-primitive/index.ts

@@ -56,15 +56,22 @@ export default class HdsDisclosurePrimitive extends Component<HdsDisclosurePrimi
     this._isOpen = value || false;
   }
 
-  private _toggleControlled = modifier(
-    (_element, [isOpen]: [boolean | undefined]) => {
+  private _toggleControlled = (() => {
+    let isFirstRun = true;
+
+    return modifier((_element, [isOpen]: [boolean | undefined]) => {
+      if (isFirstRun) {
+        isFirstRun = false;
+        return;
+      }
+
       if (isOpen !== undefined) {
         this.isOpen = isOpen;
       }
 
       this._isControlled = true;
-    }
-  );
+    });
+  })();
 
   @action
   onClickToggle(): void {

showcase/app/components/page-components/accordion/sub-sections/base-elements.gts

@@ -161,6 +161,7 @@ const SubSectionBaseElements: TemplateOnlyComponent = <template>
 
   <ShwTextH4>States</ShwTextH4>
 
+  {{! This one is broken }}
   {{#each TYPES as |type|}}
     {{#let (array false true) as |booleans|}}
       <ShwTextBody>{{capitalize type}}</ShwTextBody>