Merge pull request #36 from harness/CI-11703_2

[CI-11703]: Correct pull policy enum values

Author: raghavharness

engine/spec/const.go

@@ -30,17 +30,17 @@ func (p PullPolicy) String() string {
 
 var pullPolicyID = map[PullPolicy]string{
 	PullDefault:     "default",
-	PullAlways:      "always",
-	PullIfNotExists: "if-not-exists",
-	PullNever:       "never",
+	PullAlways:      "Always",
+	PullIfNotExists: "IfNotPresent",
+	PullNever:       "Never",
 }
 
 var pullPolicyName = map[string]PullPolicy{
-	"":              PullDefault,
-	"default":       PullDefault,
-	"always":        PullAlways,
-	"if-not-exists": PullIfNotExists,
-	"never":         PullNever,
+	"":             PullDefault,
+	"default":      PullDefault,
+	"Always":       PullAlways,
+	"IfNotPresent": PullIfNotExists,
+	"Never":        PullNever,
 }
 
 // MarshalJSON marshals the string representation of the

engine/spec/const_test.go

@@ -21,19 +21,19 @@ func TestPullPolicy_Marshal(t *testing.T) {
 	}{
 		{
 			policy: PullAlways,
-			data:   `"always"`,
+			data:   `"Always"`,
 		},
 		{
 			policy: PullDefault,
 			data:   `"default"`,
 		},
 		{
 			policy: PullIfNotExists,
-			data:   `"if-not-exists"`,
+			data:   `"IfNotPresent"`,
 		},
 		{
 			policy: PullNever,
-			data:   `"never"`,
+			data:   `"Never"`,
 		},
 	}
 	for _, test := range tests {
@@ -55,19 +55,19 @@ func TestPullPolicy_Unmarshal(t *testing.T) {
 	}{
 		{
 			policy: PullAlways,
-			data:   `"always"`,
+			data:   `"Always"`,
 		},
 		{
 			policy: PullDefault,
 			data:   `"default"`,
 		},
 		{
 			policy: PullIfNotExists,
-			data:   `"if-not-exists"`,
+			data:   `"IfNotPresent"`,
 		},
 		{
 			policy: PullNever,
-			data:   `"never"`,
+			data:   `"Never"`,
 		},
 		{
 			// no policy should default to on-success
@@ -103,19 +103,19 @@ func TestPullPolicy_String(t *testing.T) {
 	}{
 		{
 			policy: PullAlways,
-			value:  "always",
+			value:  "Always",
 		},
 		{
 			policy: PullDefault,
 			value:  "default",
 		},
 		{
 			policy: PullIfNotExists,
-			value:  "if-not-exists",
+			value:  "IfNotPresent",
 		},
 		{
 			policy: PullNever,
-			value:  "never",
+			value:  "Never",
 		},
 	}
 	for _, test := range tests {