Skip to content

Commit 8b8fef4

Browse files
test c5n.18xlarge sporadic cluster creation failure
Signed-off-by: Hanwen <[email protected]>
1 parent 30ff88b commit 8b8fef4

File tree

2 files changed

+5
-27
lines changed

2 files changed

+5
-27
lines changed

tests/integration-tests/tests/create/test_create.py

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -84,37 +84,17 @@ def test_create_wrong_pcluster_version(
8484
assert_that(cluster.creation_response.get("failures")).is_equal_to(expected_failures)
8585

8686

87-
@pytest.mark.usefixtures("instance", "scheduler")
88-
@pytest.mark.parametrize(
89-
"imds_secured, users_allow_list",
90-
[
91-
(True, {"root": True, "pcluster-admin": True, "slurm": False}),
92-
(False, {"root": True, "pcluster-admin": True, "slurm": True}),
93-
],
94-
)
87+
@pytest.mark.usefixtures("instance", "scheduler", "os", "region")
9588
def test_create_imds_secured(
96-
imds_secured, users_allow_list, region, os, pcluster_config_reader, clusters_factory, architecture
89+
pcluster_config_reader, clusters_factory
9790
):
9891
"""
9992
Test IMDS access with different configurations.
10093
In particular, it also verifies that IMDS access is preserved on instance reboot.
10194
Also checks that the cluster instances respect the desired ImdsSupport setting.
10295
"""
103-
cluster_config = pcluster_config_reader(imds_secured=imds_secured)
104-
cluster = clusters_factory(cluster_config, raise_on_error=True)
105-
status = "required"
106-
107-
logging.info("Checking cluster access after cluster creation")
108-
assert_head_node_is_running(region, cluster)
109-
assert_aws_identity_access_is_correct(cluster, users_allow_list)
110-
assert_cluster_imds_v2_requirement_status(region, cluster, status)
111-
112-
reboot_head_node(cluster)
113-
114-
logging.info("Checking cluster access after head node reboot")
115-
assert_head_node_is_running(region, cluster)
116-
assert_aws_identity_access_is_correct(cluster, users_allow_list)
117-
assert_cluster_imds_v2_requirement_status(region, cluster, status)
96+
cluster_config = pcluster_config_reader()
97+
clusters_factory(cluster_config, raise_on_error=True)
11898

11999

120100
@pytest.mark.usefixtures("instance", "os", "scheduler")

tests/integration-tests/tests/create/test_create/test_create_imds_secured/pcluster.config.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@ HeadNode:
66
SubnetId: {{ public_subnet_id }}
77
Ssh:
88
KeyName: {{ key_name }}
9-
Imds:
10-
Secured: {{ imds_secured }}
119
Scheduling:
1210
Scheduler: {{ scheduler }}
13-
{% if scheduler == "awsbatch" %}AwsBatchQueues:{% else %}SlurmQueues:{% endif %}
11+
SlurmQueues:
1412
- Name: compute
1513
ComputeResources:
1614
- Name: compute-i1

0 commit comments

Comments
 (0)