You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It has been supplanted by other struct STypes for projections. And it's
not used at current and cannot be constructed outside of the parser. It
was never serialized in a durable fashion and so its removal is safe.
Security Assessment
This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP
hail-is/hail#15868: Updates the IRParser.ptype_expr contract used by the parser branch removed here.
hail-is/hail#15872: Updates PSubsetStruct method signatures before the type is removed here.
Merge Risk: Minimal · up to f4b36
No concrete merge-blocking regression is established. Compatibility with older files containing serialized PSubsetStruct values remains unverified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly identifies the main change: removal of PSubsetStruct.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description gives a short rationale: PSubsetStruct was supplanted by other struct STypes for projections, is unused, could only be built inside the parser, and was never serialized durably, so rem…
Full details: Description check
Explanation
The description gives a short rationale: PSubsetStruct was supplanted by other struct STypes for projections, is unused, could only be built inside the parser, and was never serialized durably, so removal is safe. It also includes the Security Assessment section with the 'cannot impact' option selected. The template's Change Description section has no linked issue and no 'Fixes #' line, and the author did not delete that placeholder. The Impact Rating, Impact Description, and Appsec Review sections were correctly removed because the change has no impact. The rationale is brief, but it covers the required points for a removal PR, so the description is mostly complete.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This deals with the resolved wontfix comment by the bot on #15665. The model objected to the potential possibility of a double field in the subset struct. This removes that possibility.
Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.
Deleting the PSubsetStruct parser branch may make older serialized physical-type strings unreadable through IRParser.parsePType or another caller of ptype_expr.
The file read fails while parsing its type metadata.
This can occur when: An existing file contains a serialized physical type using PSubsetStruct syntax and is opened after the upgrade.
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 81b92b86-163d-4e81-8270-05de57acfd38
Commits
Reviewing files that changed from the base of the PR and between de32429 and f4b3622.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
It has been supplanted by other struct STypes for projections. And it's
not used at current and cannot be constructed outside of the parser. It
was never serialized in a durable fashion and so its removal is safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
It has been supplanted by other struct STypes for projections. And it's
not used at current and cannot be constructed outside of the parser. It
was never serialized in a durable fashion and so its removal is safe.
Security Assessment