[query] Add fisher_exact_test pvalue_only #15069
Open
+156
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-schultz
changed the title
patrick-schultz
force-pushed
the
ps/push-yyslnqmryskq
branch
2 times, most recently
from
beeb4ff to
0abf732
Compare
patrick-schultz
force-pushed
the
ps/push-yyslnqmryskq
branch
from
0abf732 to
014b831
Compare
patrick-schultz
force-pushed
the
ps/push-yyslnqmryskq
branch
from
014b831 to
bb011b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add a flag
_pvalue_onlytofisher_exact_test. This makes the result struct only contain the pvalue, and uses an optimized method in that case. I've left the flag underscored and undocumented for now, as ideally the PruneDeadFields pass should be able to recognize when only the pvalue field is used, and switch to the optimized implementation. However, that would need some nontrivial changes to PruneDeadFields.The motivation for this is for use cases calling
fisher_exact_testinside a loop performing a permutation test, where this might run 100k to 1m times per row.The optimized implementation is inspired by SciPy, see https://github.com/scipy/scipy/blob/v1.16.2/scipy/stats/_stats_py.py#L5055. I've also added some extra tests to be sure of the correctness of the new algorithm, including copying test cases from SciPy.
Security Assessment