Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a better name for R the radial coordinate #67

Open
EmilyBourne opened this issue Jan 31, 2025 · 1 comment
Open

Choose a better name for R the radial coordinate #67

EmilyBourne opened this issue Jan 31, 2025 · 1 comment

Comments

@EmilyBourne
Copy link
Member

Choose a better name for R the radial coordinate. In equations it is usually referred to as r and R represents something else. However in C++ capitalisation is usually used for classes while lowercase letters are used for variable names

@EmilyBourne
Copy link
Member Author

After discussion with @gdgirard and @PaulineVidal we suggest Rminor and Rmajor in files where there may be confusion (e.g. simulations). In files which are specific to a known geometry R is permitted. E.g. R is permitted in a class handling a polar plane only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant