Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt EdgeTransformation operator to periodic case #62

Open
PaulineVidal opened this issue Jan 17, 2025 · 0 comments
Open

Adapt EdgeTransformation operator to periodic case #62

PaulineVidal opened this issue Jan 17, 2025 · 0 comments

Comments

@PaulineVidal
Copy link
Collaborator

PaulineVidal commented Jan 17, 2025

The problem with the periodic case is that the ddc::coordinate(idx_range.back()) do not return the maximum value on the domain.

Eg. on \([0, 2\pi]\) , it returns \(2\pi - d\theta\).

So the way the operator is written is not adapted to this case.

One idea is that for the periodic case, we can work with idx_range.back() +1 instead of idx_range.back() and ddc::coordinate(target_idx_max) + ddc::distance_right(target_idx_max) for the last point. At the end, correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant