Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error/failure check HTTP requests #20

Open
gwynethsc opened this issue Jun 5, 2020 · 0 comments
Open

error/failure check HTTP requests #20

gwynethsc opened this issue Jun 5, 2020 · 0 comments

Comments

@gwynethsc
Copy link
Owner

Not something you need to handle now, just more of a learning point for the future. When making calls to the server, you should also check for errors/failures. That way you can show a nice toast/popup message if for some reason the delete fails.

Another learning point, you do not need to reload your all your comments on delete. You could potential just verify the response was successful and use javascript to remove that one comment or all comments. This makes your website snappier and prevents excess calls to your server/database.

Again, you don't need to make these changes, I just wanted to give you some advice on what to research if you wanted. to improve your current implementation.

Originally posted by @Google-JM in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant