Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail about building docker images locally #1064

Open
kerchner opened this issue Apr 11, 2021 · 1 comment
Open

Add detail about building docker images locally #1064

kerchner opened this issue Apr 11, 2021 · 1 comment

Comments

@kerchner
Copy link
Member

kerchner commented Apr 11, 2021

Update https://sfm.readthedocs.io/en/stable/development.html#building-vs-pulling and/or provide an example.dev.docker-compose.yml as part of the sfm-docker repo, to contain information along the lines of (thanks @lwrubel ):

If you're changing a Dockerfile or even the scripts referenced there (such as invoke.sh), I think it needs to be rebuilt. You can use the build statement in the docker-compose, like you said. You can also then add a --build flag to docker-compose up -d in order to force the build the next time, even if there is already an image saved from a previous local build.

   build:
       context: ../sfm-twitter-harvester
       dockerfile: Dockerfile-rest-harvester

docker-compose up -d --build
or
docker-compose build --no-cache
docker-compose up -d

@lwrubel
Copy link
Collaborator

lwrubel commented May 24, 2021

Note that if the sfm-base image (or the setup_reqs.sh it references) is changed and the sfm-base image is locally built, that copy will not get used when referenced in other Dockerfiles, since they refer to a particular sfm-base digest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants