Skip to content

Tutorial Day 1 review #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 3 tasks
martinberoiz opened this issue Apr 2, 2025 · 1 comment
Open
1 of 3 tasks

Tutorial Day 1 review #30

martinberoiz opened this issue Apr 2, 2025 · 1 comment

Comments

@martinberoiz
Copy link
Contributor

martinberoiz commented Apr 2, 2025

From a review:

  • In Day 1, Tutorial 2, the import gwpy command takes a very long time, presumably because of "Matplotlib is building the font cache; this may take a moment". It would be good to have a comment for this step noting that it takes some time to initialize. DONE (see Remove pylab #35)
  • In Day 1, Tutorial 3, the Q-Scan challenge would benefit from motivating why the time range should be much smaller, i.e., this event was for a binary black hole.
  • In Day 1, Tutorial 4, Exercise 1.4.3, I would recommend providing a waveform, I used and suggest IMRPhenomPv2 successfully (IMRPhenomPv2_NRTidal worked for me also). The reason for this is that the waveform on the event page with the parameters (the student is pointed to) is based on a combined samples from different priors and does not map to one of the LAL waveforms listed in this tutorial.
This was referenced Apr 4, 2025
@duboism
Copy link
Contributor

duboism commented Apr 10, 2025

Part of this were fixed in #35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants