Fix omitempty panic for double-embedded struct (#247)

Author: guregu

encode_test.go

@@ -152,6 +152,40 @@ func TestMarshalItemAsymmetric(t *testing.T) {
 	}
 }
 
+func TestIssue247(t *testing.T) {
+	// https: //github.com/guregu/dynamo/issues/247
+	type ServerResponse struct {
+		EmbeddedID int
+	}
+	type TestAddition struct {
+		ServerResponse
+	}
+	type TestItem struct {
+		ID       int          `dynamo:"id,hash" json:"id"`
+		Name     string       `dynamo:"name,range" json:"name"`
+		Addition TestAddition `dynamo:"addition,omitempty"`
+	}
+	x := TestItem{ID: 1, Name: "test"}
+	item, err := MarshalItem(x)
+	if err != nil {
+		t.Fatal(err)
+	}
+	_, ok := item["addition"]
+	if ok {
+		t.Error("should be omitted")
+	}
+
+	x.Addition.EmbeddedID = 123
+	item, err = MarshalItem(x)
+	if err != nil {
+		t.Fatal(err)
+	}
+	_, ok = item["addition"]
+	if !ok {
+		t.Error("should be present")
+	}
+}
+
 type isValue_Kind interface {
 	isValue_Kind()
 }

reflect.go

@@ -250,8 +250,12 @@ func (info *structInfo) isZero(rv reflect.Value) bool {
 	}
 	for _, field := range info.fields {
 		fv := dig(rv, field.index)
-		if !fv.IsValid() {
-			// TODO: encode NULL?
+		if !fv.IsValid() /* field doesn't exist */ {
+			continue
+		}
+		if field.isZero == nil {
+			// TODO: https://github.com/guregu/dynamo/issues/247
+			// need to give child structs an isZero
 			continue
 		}
 		if !field.isZero(fv) {