Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Captions Ignoring Padding On Body Images With Role "Immersive" #11028

Open
JamieB-gu opened this issue Mar 26, 2024 · 0 comments · May be fixed by #13163
Open

Captions Ignoring Padding On Body Images With Role "Immersive" #11028

JamieB-gu opened this issue Mar 26, 2024 · 0 comments · May be fixed by #13163
Assignees
@jamesmockett
Labels
Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work. Team Candidate: Articles and Publishing
Milestone
Requests

Comments

@JamieB-gu
Copy link
Contributor

We'd like the captions to keep the normal body padding, as they do for images with other roles (e.g. "showcase").

As seen on this piece: https://www.theguardian.com/world/2024/mar/14/solidarity-and-strategy-the-forgotten-lessons-of-truly-effective-protest

Immersive Role Showcase Role
immersive-body-image showcase-body-image
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Mar 26, 2024
@JamieB-gu JamieB-gu added the Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work. label Mar 26, 2024
@JamieB-gu JamieB-gu added this to the Requests milestone Mar 26, 2024
@alinaboghiu alinaboghiu moved this from Triage to This Sprint in WebX Team Apr 4, 2024
@ioannakok ioannakok moved this from This Sprint to Backlog in WebX Team Apr 10, 2024
@shesah shesah moved this from Backlog to Archived in WebX Team Apr 26, 2024
@JamieB-gu JamieB-gu moved this from Archived to Triage in WebX Team Nov 1, 2024
@shesah shesah added the Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… label Nov 15, 2024
@shesah shesah moved this from Triage to Backlog in WebX Team Nov 15, 2024
@jamesmockett jamesmockett self-assigned this Jan 13, 2025
@jamesmockett jamesmockett moved this from Backlog to In Progress in WebX Team Jan 13, 2025
@jamesmockett jamesmockett moved this from In Progress to Review in WebX Team Jan 16, 2025
@jamesmockett jamesmockett linked a pull request Jan 16, 2025 that will close this issue
Apply padding to immersive image captions #13163
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmockett jamesmockett

Labels
Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work. Team Candidate: Articles and Publishing
Projects
WebX Team
Status: Review
Milestone
Requests
Development

Successfully merging a pull request may close this issue.

Apply padding to immersive image captions guardian/dotcom-rendering
3 participants
@jamesmockett @shesah @JamieB-gu