-
Notifications
You must be signed in to change notification settings - Fork 190
fix: Missing VEX status mappings for resolved_with_pedigree and false_positive #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
funnelfiasco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to resolving the addition of a GitHub workflow, you will need to include a DCO signoff before this change can be approved.
61aa4aa to
56a00d1
Compare
lumjjb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening up this PR! Looks great with some minor comment!
…positive Signed-off-by: Irena Liu <[email protected]>
…uses Signed-off-by: Irena Liu <[email protected]>
0201225 to
644fe18
Compare
lumjjb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, minor comment, and started the workflow for tests!
644fe18 to
064b713
Compare
lumjjb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with requirement to one test for the new code path (see comment).. Thanks @irenaliu18 !
Signed-off-by: Irena Liu <[email protected]>
064b713 to
c51c29d
Compare
pxp928
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank You
funnelfiasco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearing my change request since the issues have been addressed and the test failures are systemic.
|
I'm currently checking on which CI tests are broken we should fix/ignored (#2820) to make sure to unblock this if the failures are not caused by this PR |
|
HI @irenaliu18, i fixed some of the CI checks, can you rebase and reupload the PR? and i can run the tests again! |
Description of the PR
This PR addresses issue 2812, adding support for two missing CycloneDX 1.6 VEX (Vulnerability Exploitability eXchange) status values:
resolved_with_pedigreeandfalse_positive. These statuses were introduced in CycloneDX 1.5+ but were not previously handled by the GUAC parser, causing ingestion failures with the error "unknown vulnerability status".GUAC currently fails to ingest CycloneDX 1.6 SBOMs containing the following VEX statuses:
resolved_with_pedigree- Indicates the vulnerability has been remediated with evidence provided in component pedigreefalse_positive- Indicates the vulnerability was falsely identified or associated with the componentUnit Tests
New test cases pass:
Test_cyclonedxParser/valid_CycloneDX_VEX_document_with_resolved_with_pedigree_statusTest_cyclonedxParser/valid_CycloneDX_VEX_document_with_false_positive_statusgo test ./pkg/ingestor/parser/cyclonedx/... -vPR Checklist
-sflag togit commit.make generatehas been runmake generatehas been runmake generatehas been runcollectsubprotobuf has been changed,make protohas been run