clippy: run with --all-features

this should lets us catch some behind feature flag clippy warnings
and fixes the current ones

Author: bilelmoussaoui

.github/workflows/CI.yml

@@ -135,7 +135,7 @@ jobs:
       - uses: actions-rs/cargo@v1
         with:
           command: clippy
-          args: -- -D warnings
+          args: --all-features -- -D warnings
 
   checker:
     name: gtk-rs checker

cairo/src/font/font_options.rs

@@ -121,7 +121,9 @@ impl FontOptions {
                     let v = CString::new(*v).unwrap();
                     ffi::cairo_font_options_set_variations(self.to_raw_none(), v.as_ptr())
                 }
-                None => ffi::cairo_font_options_set_variations(self.to_raw_none(), 0 as *const _),
+                None => {
+                    ffi::cairo_font_options_set_variations(self.to_raw_none(), std::ptr::null())
+                }
             }
         }
     }

examples/src/bin/notebook.rs

@@ -25,7 +25,6 @@ impl Notebook {
         let tab = gtk::Box::new(Orientation::Horizontal, 0);
 
         button.set_relief(ReliefStyle::None);
-        button.set_focus_on_click(false);
         button.add(&close_image);
 
         tab.pack_start(&label, false, false, 0);

gdk-pixbuf/src/pixbuf.rs

@@ -396,6 +396,7 @@ impl Pixbuf {
     }
 
     #[cfg(any(feature = "v2_32", feature = "dox"))]
+    #[allow(clippy::type_complexity)]
     pub fn get_file_info_async_future<T: AsRef<Path> + Clone + 'static>(
         filename: T,
     ) -> Pin<Box<dyn Future<Output = Result<Option<(PixbufFormat, i32, i32)>, Error>> + 'static>>
@@ -438,7 +439,7 @@ impl Pixbuf {
     }
 
     #[cfg(any(feature = "v2_36", feature = "dox"))]
-    pub fn save_to_streamv<'a, P: IsA<gio::OutputStream>, Q: IsA<gio::Cancellable>>(
+    pub fn save_to_streamv<P: IsA<gio::OutputStream>, Q: IsA<gio::Cancellable>>(
         &self,
         stream: &P,
         type_: &str,
@@ -469,7 +470,6 @@ impl Pixbuf {
 
     #[cfg(any(feature = "v2_36", feature = "dox"))]
     pub fn save_to_streamv_async<
-        'a,
         P: IsA<gio::OutputStream>,
         Q: IsA<gio::Cancellable>,
         R: FnOnce(Result<(), Error>) + Send + 'static,

gdk/src/cairo_interaction.rs

@@ -49,6 +49,7 @@ pub trait GdkContextExt {
     fn create_from_window<W: IsA<Window>>(window: &W) -> Context;
 
     #[cfg(any(feature = "v3_16", feature = "dox"))]
+    #[allow(clippy::too_many_arguments)]
     unsafe fn draw_from_gl<W: IsA<Window>>(
         &self,
         window: &W,

gdkx11/build.rs

@@ -5,8 +5,8 @@ fn main() {
 #[cfg(any(feature = "embed-lgpl-docs", feature = "purge-lgpl-docs"))]
 fn manage_docs() {
     extern crate lgpl_docs;
-    const PATH: &'static str = "src";
-    const IGNORES: &'static [&'static str] = &["lib.rs"];
+    const PATH: &str = "src";
+    const IGNORES: &[&str] = &["lib.rs"];
     lgpl_docs::purge(PATH, IGNORES);
     if cfg!(feature = "embed-lgpl-docs") {
         lgpl_docs::embed(lgpl_docs::Library::SourceView, PATH, IGNORES);

gio/src/lib.rs

@@ -4,6 +4,7 @@
 
 #![allow(clippy::type_complexity)]
 #![allow(clippy::too_many_arguments)]
+#![allow(clippy::missing_safety_doc)]
 #![allow(deprecated)]
 
 #[macro_use]

gio/src/unix_output_stream.rs

@@ -14,7 +14,6 @@ use std::os::unix::io::{AsRawFd, FromRawFd, IntoRawFd, RawFd};
 use socket::{AsRawFd, FromRawFd, IntoRawFd, RawFd};
 
 impl UnixOutputStream {
-    #[allow(clippy::missing_safety_doc)]
     pub unsafe fn new<T: IntoRawFd>(fd: T) -> UnixOutputStream {
         let fd = fd.into_raw_fd();
         let close_fd = true.to_glib();
@@ -30,7 +29,6 @@ impl AsRawFd for UnixOutputStream {
 
 pub trait UnixOutputStreamExtManual: Sized {
     fn get_fd<T: FromRawFd>(&self) -> T;
-    #[allow(clippy::missing_safety_doc)]
     unsafe fn set_close_fd(&self, close_fd: bool);
 }
 

glib/src/object.rs

@@ -1282,7 +1282,6 @@ pub trait ObjectExt: ObjectType {
         name: Option<&str>,
         f: F,
     ) -> SignalHandlerId;
-    #[allow(clippy::missing_safety_doc)]
     unsafe fn connect_notify_unsafe<F: Fn(&Self, &::ParamSpec)>(
         &self,
         name: Option<&str>,