Merge pull request #907 from cjihrig/session

 grpc-js: destroy connections when session begins

Author: murgatroid99

packages/grpc-js/src/channel.ts

@@ -329,8 +329,8 @@ export class Http2Channel extends EventEmitter implements Channel {
     stream: Http2CallStream,
     metadata: Metadata
   ) {
-    const connectMetadata: Promise<Metadata> = this.connect().then(
-      () => metadata.clone()
+    const connectMetadata: Promise<Metadata> = this.connect().then(() =>
+      metadata.clone()
     );
     const finalMetadata: Promise<Metadata> = stream.filterStack.sendMetadata(
       connectMetadata

packages/grpc-js/src/server.ts

@@ -284,11 +284,6 @@ export class Server {
     this.http2Server.on(
       'stream',
       (stream: http2.ServerHttp2Stream, headers: http2.IncomingHttpHeaders) => {
-        if (!this.started) {
-          stream.end();
-          return;
-        }
-
         const contentType = headers[http2.constants.HTTP2_HEADER_CONTENT_TYPE];
 
         if (
@@ -351,6 +346,13 @@ export class Server {
         }
       }
     );
+
+    this.http2Server.on('session', session => {
+      if (!this.started) {
+        session.destroy();
+        return;
+      }
+    });
   }
 }
 

packages/grpc-js/src/stream-decoder.ts

@@ -33,7 +33,7 @@ export class StreamDecoder {
   write(data: Buffer): Buffer[] {
     let readHead = 0;
     let toRead: number;
-    let result: Buffer[] = [];
+    const result: Buffer[] = [];
 
     while (readHead < data.length) {
       switch (this.readState) {