Skip to content

Commit c186e6d

Browse files
authored
Merge pull request #943 from mrfelton/fix/404-handling
fix: properly handle http error status codes
2 parents fde180a + aa54122 commit c186e6d

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

packages/grpc-js/src/call-stream.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -243,24 +243,24 @@ export class Http2CallStream extends Duplex implements Call {
243243
} else {
244244
this.http2Stream = stream;
245245
stream.on('response', (headers, flags) => {
246-
switch (headers[HTTP2_HEADER_STATUS]) {
246+
switch (headers[':status']) {
247247
// TODO(murgatroid99): handle 100 and 101
248-
case '400':
248+
case 400:
249249
this.mappedStatusCode = Status.INTERNAL;
250250
break;
251-
case '401':
251+
case 401:
252252
this.mappedStatusCode = Status.UNAUTHENTICATED;
253253
break;
254-
case '403':
254+
case 403:
255255
this.mappedStatusCode = Status.PERMISSION_DENIED;
256256
break;
257-
case '404':
257+
case 404:
258258
this.mappedStatusCode = Status.UNIMPLEMENTED;
259259
break;
260-
case '429':
261-
case '502':
262-
case '503':
263-
case '504':
260+
case 429:
261+
case 502:
262+
case 503:
263+
case 504:
264264
this.mappedStatusCode = Status.UNAVAILABLE;
265265
break;
266266
default:

0 commit comments

Comments
 (0)