Skip to content

Tracking Issue for setOnCloseHandler being Experimental #8467

Open
@morgwai

Description

@morgwai

To resolve issue #5895 PR #8452 has been created that adds new ServerCallStreamObserver.setOnFinishHandler(...) method.
The handler is called by Listener.onComplete when the call is finished correctly from the server's point of view: either onCompleted() or onError(Throwable) has been called, all the messages and trailing metadata have been put on the wire and the stream has been closed.

Several names were proposed for the handler:

  • onCompleteHandler : derives name from Listener's method but causes confusion with StreamObserver.onCompleted()
  • onSuccessHandler : my initial idea, yet also confusing as it can be called also after StreamObserver.onError(...)
  • onFinishHandler : current approach, matches well the verb from method's javadoc
  • onFinalizeHandler : would also probably do well

Metadata

Metadata

Assignees

No one assigned

    Labels

    experimental APIIssue tracks stabilizing an experimental API

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions