Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking GrpclbLoadBalancerTest unit tests should be more unitary #2772

Open
dapengzhang0 opened this issue Mar 1, 2017 · 0 comments · May be fixed by #11677
Open

Tracking GrpclbLoadBalancerTest unit tests should be more unitary #2772

dapengzhang0 opened this issue Mar 1, 2017 · 0 comments · May be fixed by #11677
Labels
code health
Milestone
Next

Comments

@dapengzhang0
Copy link
Member

dapengzhang0 commented Mar 1, 2017 •
edited by ejona86
Loading

Some unit tests in GrpclbLoadBalancerTest are too long and testing multiple things in one test method.
It's hard to read and maintain. Better to split apart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

grpclb: Refactoring GrpclbLoadBalancerTest unit tests SreeramdasLavanya/grpc-java
2 participants
@ejona86 @dapengzhang0