Skip to content

Commit 5f95085

Browse files
committed
Fix build after rebase.
1 parent c6734a8 commit 5f95085

File tree

3 files changed

+34
-15
lines changed

3 files changed

+34
-15
lines changed

core/src/main/java/io/grpc/internal/TransportSet.java

Lines changed: 29 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,8 @@
5757
* Transports for a single {@link SocketAddress}.
5858
*/
5959
@ThreadSafe
60-
final class TransportSet {
60+
final class TransportSet implements WithLogId {
6161
private static final Logger log = Logger.getLogger(TransportSet.class.getName());
62-
6362
private static final ClientTransport SHUTDOWN_TRANSPORT =
6463
new FailingClientTransport(Status.UNAVAILABLE.withDescription("TransportSet is shutdown"));
6564

@@ -192,7 +191,10 @@ public void run() {
192191
}
193192
ManagedClientTransport transport =
194193
transportFactory.newClientTransport(address, authority);
195-
log.log(Level.FINE, "Created transport {0} for {1}", new Object[] {transport, address});
194+
if (log.isLoggable(Level.FINE)) {
195+
log.log(Level.FINE, "[{0}] Created {1} for {2}",
196+
new Object[] {getLogId(), transport.getLogId(), address});
197+
}
196198
transports.add(transport);
197199
transport.start(new TransportListener(transport, delayedTransport, address));
198200
}
@@ -211,6 +213,10 @@ public void run() {
211213
}
212214
}
213215
firstAttempt = false;
216+
if (log.isLoggable(Level.FINE)) {
217+
log.log(Level.FINE, "[{0}] Scheduling connection after {1} ms for {2}",
218+
new Object[]{getLogId(), delayMillis, address});
219+
}
214220
if (delayMillis <= 0) {
215221
reconnectTask = null;
216222
// No back-off this time.
@@ -257,6 +263,11 @@ private void cancelReconnectTask() {
257263
}
258264
}
259265

266+
@Override
267+
public String getLogId() {
268+
return GrpcUtil.getLogId(this);
269+
}
270+
260271
/** Shared base for both delayed and real transports. */
261272
private class BaseTransportListener implements ManagedClientTransport.Listener {
262273
protected final ManagedClientTransport transport;
@@ -277,6 +288,9 @@ public void transportTerminated() {
277288
synchronized (lock) {
278289
transports.remove(transport);
279290
if (shutdown && transports.isEmpty()) {
291+
if (log.isLoggable(Level.FINE)) {
292+
log.log(Level.FINE, "[{0}] Terminated", getLogId());
293+
}
280294
runCallback = true;
281295
cancelReconnectTask();
282296
}
@@ -301,7 +315,10 @@ public TransportListener(ManagedClientTransport transport,
301315

302316
@Override
303317
public void transportReady() {
304-
log.log(Level.FINE, "Transport {0} for {1} is ready", new Object[] {transport, address});
318+
if (log.isLoggable(Level.FINE)) {
319+
log.log(Level.FINE, "[{0}] {1} for {2} is ready",
320+
new Object[] {getLogId(), transport.getLogId(), address});
321+
}
305322
super.transportReady();
306323
boolean savedShutdown;
307324
synchronized (lock) {
@@ -330,8 +347,10 @@ public void transportReady() {
330347

331348
@Override
332349
public void transportShutdown(Status s) {
333-
log.log(Level.FINE, "Transport {0} for {1} is being shutdown with {2}",
334-
new Object[] {transport, address, s});
350+
if (log.isLoggable(Level.FINE)) {
351+
log.log(Level.FINE, "[{0}] {1} for {2} is being shutdown with status {3}",
352+
new Object[] {getLogId(), transport.getLogId(), address, s});
353+
}
335354
super.transportShutdown(s);
336355
synchronized (lock) {
337356
if (activeTransport == transport) {
@@ -353,8 +372,10 @@ public void transportShutdown(Status s) {
353372

354373
@Override
355374
public void transportTerminated() {
356-
log.log(Level.FINE, "Transport {0} for {1} is terminated",
357-
new Object[] {transport, address});
375+
if (log.isLoggable(Level.FINE)) {
376+
log.log(Level.FINE, "[{0}] {1} for {2} is terminated",
377+
new Object[] {getLogId(), transport.getLogId(), address});
378+
}
358379
super.transportTerminated();
359380
Preconditions.checkState(activeTransport != transport,
360381
"activeTransport still points to the delayedTransport. "

core/src/test/java/io/grpc/internal/ManagedChannelImplTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ public void twoCallsAndGracefulShutdown() {
200200
transportListener.transportReady();
201201
verify(mockTransport, timeout(1000)).newStream(same(method), same(headers));
202202
verify(mockStream).start(streamListenerCaptor.capture());
203-
verify(mockStream).setMessageCompression(anyBoolean());
204203
verify(mockStream).setCompressor(isA(Compressor.class));
205204
// Depends on how quick the real transport is created, ClientCallImpl may start on mockStream
206205
// directly, or on a DelayedStream which later starts mockStream. In the former case,

core/src/test/java/io/grpc/internal/ManagedChannelImplTransportManagerTest.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,12 @@ public void createAndReuseTransport() throws Exception {
165165
ClientTransport t1 = tm.getTransport(addressGroup);
166166
verify(mockTransportFactory, timeout(1000)).newClientTransport(addr, authority);
167167
// The real transport
168-
ClientTransport rt = transports.poll(1, TimeUnit.SECONDS).transport;
168+
MockClientTransportInfo transportInfo = transports.poll(1, TimeUnit.SECONDS);
169+
transportInfo.listener.transportReady();
169170
ClientTransport t2 = tm.getTransport(addressGroup);
170-
// Make sure the first transport is always a real transport. This promise is especially made for
171-
// InProcessTransport, because it may run into deadlock if it works under a delayed transport
172-
// (https://github.com/grpc/grpc-java/issues/1510).
173-
assertSame(rt, t1);
174-
assertSame(rt, t2);
171+
assertTrue(t1 instanceof DelayedClientTransport);
172+
assertFalse(t2 instanceof DelayedClientTransport);
173+
assertSame(transportInfo.transport, t2);
175174
verify(mockBackoffPolicyProvider).get();
176175
verify(mockBackoffPolicy, times(0)).nextBackoffMillis();
177176
verifyNoMoreInteractions(mockTransportFactory);

0 commit comments

Comments
 (0)