Skip to content

Transfer the repository to grpc-ecosystem/grpc-spring #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattdkerr opened this issue Dec 20, 2018 · 7 comments
Closed

Transfer the repository to grpc-ecosystem/grpc-spring #164

mattdkerr opened this issue Dec 20, 2018 · 7 comments
Assignees
Labels
enhancement A feature request or improvement
Milestone

Comments

@mattdkerr
Copy link
Contributor

This repo has the same artifact name, which leads to confusion as to which one you are using in your build. https://github.com/LogNet/grpc-spring-boot-starter
This is unfortunate because it doesn't offer as many features as this one. (Perhaps it's also time to ask if we can migrate this from a personal project area to one of the main Spring ones?)

@yidongnan
Copy link
Collaborator

yidongnan commented Dec 21, 2018

If Spring needs an official gRPC project with spring boot, I am happy to migrate this to Spring 😄
At the same time, I did not find a way to submit application and project requirements.

@ST-DDT
Copy link
Collaborator

ST-DDT commented Dec 21, 2018

This repo has the same artifact name, which leads to confusion as to which one you are using in your build. https://github.com/LogNet/grpc-spring-boot-starter
This is unfortunate because it doesn't offer as many features as this one.

IIRC there are two different philosophies behind both repositories. This one contains more features and thus is bigger and more complex. The other library wants to remain as small as possible.

(Perhaps it's also time to ask if we can migrate this from a personal project area to one of the main Spring ones?)

I have no experience with this process. Getting the official "spring" stamp might be helpful for the google search result ranking, but I'm unsure on the implications. @mattdkerr do you know any details regarding that process?

@ST-DDT ST-DDT added the enhancement A feature request or improvement label Dec 21, 2018
ST-DDT referenced this issue in spring-cloud/spring-cloud-sleuth Feb 8, 2019
* Adding preliminary GRPC instrumentation to Sleuth

fixes #305
@ST-DDT
Copy link
Collaborator

ST-DDT commented Feb 16, 2019

It looks like there is a spring issue to provide gRPC support: spring-projects/spring-framework#20905

@ST-DDT ST-DDT changed the title Project name is easily confused with LogNet Become a Spring-Project / Project name confusion with LogNet Feb 16, 2019
@ST-DDT ST-DDT added help wanted Requesting external help on hold Currently no progress possible labels Apr 17, 2019
@ST-DDT
Copy link
Collaborator

ST-DDT commented Apr 17, 2019

We probably need some external/Spring help for this.

@mattdkerr
Copy link
Contributor Author

Sorry, I don't know how this works, but I think we have a contact at Pivotal. I'll see if I can get a pointer next week.

@mattdkerr
Copy link
Contributor Author

It looks like there is a spring issue to provide gRPC support: spring-projects/spring-framework#20905

added my 2cents to this thread

@ST-DDT ST-DDT added this to the Future milestone Jun 13, 2020
@yidongnan
Copy link
Collaborator

yidongnan commented Oct 18, 2023

After discussions, we have decided to transfer the repository to https://github.com/grpc-ecosystem/grpc-spring, and Google's team will also be actively involved in its development. This project will eventually become the official project for supporting gRPC with Spring.

We appreciate your support and interest in the project.

@yidongnan yidongnan removed help wanted Requesting external help on hold Currently no progress possible labels Oct 18, 2023
@yidongnan yidongnan modified the milestones: Future, 3.0.0 Oct 18, 2023
@yidongnan yidongnan pinned this issue Oct 18, 2023
@yidongnan yidongnan changed the title Become a Spring-Project / Project name confusion with LogNet Transfer the repository to https://github.com/grpc-ecosystem/grpc-spring Oct 18, 2023
@yidongnan yidongnan self-assigned this Oct 18, 2023
@yidongnan yidongnan changed the title Transfer the repository to https://github.com/grpc-ecosystem/grpc-spring Transfer the repository to grpc-ecosystem/grpc-spring Oct 18, 2023
@yidongnan yidongnan unpinned this issue Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request or improvement
Projects
None yet
Development

No branches or pull requests

3 participants