Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox - Code Parity review #4604

Closed
SeamusLeonardHPE opened this issue Dec 16, 2024 · 2 comments
Closed

Checkbox - Code Parity review #4604

SeamusLeonardHPE opened this issue Dec 16, 2024 · 2 comments
Assignees
@britt6612
Labels
Phase:Current Sprint Used for issues that are being worked on current sprint.

Comments

@SeamusLeonardHPE
Copy link
Collaborator

Review checkbox component for alignment with Grommet props

https://www.figma.com/design/5NUO23O2mDjiulO2H0S2Os/v2-Construction-Site?node-id=5012-58260&t=P9ZIdBb6Hf53Whzq-4
@britt6612
Copy link
Collaborator

@SeamusLeonardHPE

The only thing that I saw was the validation state does not look to be the correct color.
Everything else looks good as far as the props are!

@SeamusLeonardHPE SeamusLeonardHPE added the Phase:Current Sprint Used for issues that are being worked on current sprint. label Dec 17, 2024
@SeamusLeonardHPE
Copy link
Collaborator Author

Issue with color on dev playground - not in figma canvas - checked and values are all correct

Closed as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@britt6612 britt6612

Labels
Phase:Current Sprint Used for issues that are being worked on current sprint.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@britt6612 @SeamusLeonardHPE