Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Input [in Formfield] - Token review #4599

Closed
SeamusLeonardHPE opened this issue Dec 16, 2024 · 2 comments
Closed

Search Input [in Formfield] - Token review #4599

SeamusLeonardHPE opened this issue Dec 16, 2024 · 2 comments
Assignees
@SeamusLeonardHPE

Comments

@SeamusLeonardHPE
Copy link
Collaborator

SeamusLeonardHPE commented Dec 16, 2024 •
edited
Loading

Link to region

https://www.figma.com/design/5NUO23O2mDjiulO2H0S2Os/v2-Construction-Site?node-id=4766-53756&t=P9ZIdBb6Hf53Whzq-4

NOtes

  1. Only "parts" require token testing since the main component is a duplicate of the already tested textinput -
  2. Search typeahead item was build using semantic tokens as advised by Oliver
@CillianHPE CillianHPE added the Phase:Current Sprint Used for issues that are being worked on current sprint. label Dec 16, 2024
@CillianHPE
Copy link
Collaborator

@SeamusLeonardHPE

Look good just one minor comment.

Once you fix you can close.

@SeamusLeonardHPE
Copy link
Collaborator Author

Closing as done - token question in #4583

@oliverHPE oliverHPE removed the Phase:Current Sprint Used for issues that are being worked on current sprint. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeamusLeonardHPE SeamusLeonardHPE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SeamusLeonardHPE @oliverHPE @CillianHPE