Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Assertions attribute values, help text, etc. to ConfigService #236

Open
jmcmichael opened this issue Oct 7, 2015 · 3 comments
Open

Comments

@jmcmichael
Copy link
Contributor

These are repeated in several places throughout the app, so should be refactored into a single location.

@malachig
Copy link
Member

Was this started? Is this the purpose of this component:

src/components/services/ConfigService.js

@jmcmichael
Copy link
Contributor Author

jmcmichael commented Jan 6, 2017

Yes, ConfigService can be injected into any component. Its intended as a global storage for form/tip/ universally to hold tool tip text, menus, etc.

In in the evidenceSummary component, configService is injected here:

https://github.com/genome/civic-client/blob/master/src/app/views/events/evidence/summary/evidenceSummary.js#L22

and assigned to its scope here:

https://github.com/genome/civic-client/blob/master/src/app/views/events/evidence/summary/evidenceSummary.js#L27

to be used in its template, e.g. here:

https://github.com/genome/civic-client/blob/master/src/app/views/events/evidence/summary/evidenceSummary.tpl.html#L40

This same pattern can be used to unify the configuration for the various Add/Edit views.

@jmcmichael
Copy link
Contributor Author

This was pretty much done but it's not as clean as it could be - the new Assertions features have help text specified directly in the field template options. These need to be moved their own Assertions section of ConfigService.

@jmcmichael jmcmichael changed the title move all field values, help text, and attribute descriptions to a config file add Assertions attribute values, help text, etc. to ConfigService Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants