Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Cleanup/Validation #1310

Open
acoffman opened this issue Jan 23, 2020 · 3 comments
Open

Source Cleanup/Validation #1310

acoffman opened this issue Jan 23, 2020 · 3 comments
Assignees
Labels

Comments

@acoffman
Copy link
Member

acoffman commented Jan 23, 2020

Add a database and model constraint to ensure a source must have a citation id.

Remove the erroneous source 2841, flag or fix EIDs impacted and add test cases to ensure evidence cannot be submitted without a source.

@susannasiebert
Copy link
Contributor

Some of the affected EIDs are rejected so we might just need to remove the source from them altogether

Up-to-date list can be found here: https://civicdb.org/sources/2841/summary

@susannasiebert susannasiebert self-assigned this Jan 24, 2020
@susannasiebert
Copy link
Contributor

Per comments on the remaining EIDs for this source (https://civicdb.org/events/genes/6281/summary/variants/2752/summary/evidence/7438 and https://civicdb.org/events/genes/11314/summary/variants/2672/summary/evidence/7229) can be totally deleted and then we can delete this source.

@susannasiebert
Copy link
Contributor

susannasiebert commented Jul 20, 2020

2841 and its associated EIDs (and their subscriptions, notifications, and events) has been removed.

@acoffman acoffman self-assigned this Aug 14, 2020
@susannasiebert susannasiebert removed their assignment Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants