Fix clippy lints

and test write access

Author: MaxVerevkin

src/blocks/networkmanager.rs

@@ -90,7 +90,7 @@ enum DeviceType {
     Wifi,
     Modem,
     Bridge,
-    TUN,
+    Tun,
     Wireguard,
 }
 
@@ -102,7 +102,7 @@ impl From<u32> for DeviceType {
             2 => DeviceType::Wifi,
             8 => DeviceType::Modem,
             13 => DeviceType::Bridge,
-            16 => DeviceType::TUN,
+            16 => DeviceType::Tun,
             29 => DeviceType::Wireguard,
             _ => DeviceType::Unknown,
         }
@@ -116,7 +116,7 @@ impl DeviceType {
             DeviceType::Wifi => Some("net_wireless".to_string()),
             DeviceType::Modem => Some("net_modem".to_string()),
             DeviceType::Bridge => Some("net_bridge".to_string()),
-            DeviceType::TUN => Some("net_bridge".to_string()),
+            DeviceType::Tun => Some("net_bridge".to_string()),
             DeviceType::Wireguard => Some("net_vpn".to_string()),
             _ => None,
         }
@@ -127,6 +127,7 @@ impl DeviceType {
 struct Ipv4Address {
     address: Ipv4Addr,
     prefix: u32,
+    #[allow(dead_code)]
     gateway: Ipv4Addr,
 }
 
@@ -491,6 +492,7 @@ pub struct NetworkManagerConfig {
     pub interface_name_include: Vec<String>,
 }
 
+#[allow(clippy::derivable_impls)]
 impl Default for NetworkManagerConfig {
     fn default() -> Self {
         Self {

src/blocks/notify.rs

@@ -28,22 +28,13 @@ pub struct Notify {
     output: TextWidget,
 }
 
-#[derive(Deserialize, Debug, Clone)]
+#[derive(Deserialize, Debug, Default, Clone)]
 #[serde(deny_unknown_fields, default)]
 pub struct NotifyConfig {
     /// Format string which describes the output of this block.
     pub format: FormatTemplate,
 }
 
-impl Default for NotifyConfig {
-    fn default() -> Self {
-        Self {
-            // display just the bell icon
-            format: FormatTemplate::default(),
-        }
-    }
-}
-
 impl ConfigBlock for Notify {
     type Config = NotifyConfig;
 

src/errors.rs

@@ -59,6 +59,8 @@ impl<T> OptionExt<T> for ::std::option::Option<T> {
 
 /// A set of errors that can occur during the runtime of i3status-rs.
 /// TODO: rewrite using struct-like fields ("what is the order of InternalError again?")
+/// TODO: rename variants
+#[allow(clippy::enum_variant_names)]
 pub enum Error {
     BlockError(String, String),
     ConfigurationError(String, String),

src/protocol/i3bar_event.rs

@@ -24,7 +24,9 @@ pub enum MouseButton {
 struct I3BarEventInternal {
     pub name: Option<String>,
     pub instance: Option<String>,
+    #[allow(dead_code)]
     pub x: u64,
+    #[allow(dead_code)]
     pub y: u64,
 
     #[serde(deserialize_with = "deserialize_mousebutton")]

src/widgets/rotatingtext.rs

@@ -8,7 +8,6 @@ use crate::util::escape_pango_text;
 
 #[derive(Clone, Debug)]
 pub struct RotatingTextWidget {
-    id: usize,
     pub instance: usize,
     pub rotating: bool,
     rotation_pos: usize,
@@ -43,7 +42,6 @@ impl RotatingTextWidget {
         };
 
         RotatingTextWidget {
-            id,
             instance,
             rotation_pos: 0,
             max_width,

src/widgets/text.rs

@@ -5,7 +5,6 @@ use crate::protocol::i3bar_block::I3BarBlock;
 
 #[derive(Clone, Debug)]
 pub struct TextWidget {
-    id: usize,
     pub instance: usize,
     content: Option<String>,
     content_short: Option<String>,
@@ -29,7 +28,6 @@ impl TextWidget {
         };
 
         TextWidget {
-            id,
             instance,
             content: None,
             content_short: None,