Regexes now has the unicode flag set

Author: robinheghan

src/Gren/Kernel/Regex.js

@@ -13,7 +13,7 @@ var _Regex_fromStringWith = F2(function (options, string) {
     return __Maybe_Nothing;
   }
 
-  var flags = "g";
+  var flags = "gu";
   if (options.__$multiline) {
     flags += "m";
   }
@@ -86,5 +86,3 @@ var _Regex_replaceAtMost = F4(function (n, re, replacer, string) {
 var _Regex_splitAtMost = F3(function (n, re, str) {
   return str.split(re, n);
 });
-
-var _Regex_infinity = Number.MAX_SAFE_INTEGER;

src/String/Regex.gren

@@ -35,6 +35,7 @@ import Array exposing (Array)
 import Basics exposing (..)
 import Maybe exposing (Maybe(..))
 import String exposing (String)
+import Math
 import Gren.Kernel.Regex
 
 
@@ -143,7 +144,7 @@ If you want some really fancy splits, a library like
 -}
 split : Regex -> String -> Array String
 split =
-  Gren.Kernel.Regex.splitAtMost Gren.Kernel.Regex.infinity
+  Gren.Kernel.Regex.splitAtMost Math.maxSafeInteger
 
 
 {-| Find matches in a string:
@@ -169,7 +170,7 @@ If you need `submatches` for some reason, a library like
 -}
 find : Regex -> String -> Array Match
 find =
-  Gren.Kernel.Regex.findAtMost Gren.Kernel.Regex.infinity
+  Gren.Kernel.Regex.findAtMost Math.maxSafeInteger
 
 
 {-| The details about a particular match:
@@ -226,7 +227,7 @@ you use the details of a specific match when making replacements.
 -}
 replace : Regex -> (Match -> String) -> String -> String
 replace =
-  Gren.Kernel.Regex.replaceAtMost Gren.Kernel.Regex.infinity
+  Gren.Kernel.Regex.replaceAtMost Math.maxSafeInteger
 
 
 

tests/src/Test/Regex.gren

@@ -14,6 +14,9 @@ tests =
         [ test "Regex.replace" <| \{} ->
             Regex.replace vowels (\_ -> "_") "abc"
                 |> Expect.equal "_bc"
+        , test "Regex has unicode enabled" <| \{} ->
+            Regex.replace smily (\_ -> "_") "you are all 🙂 aren't you?"
+                |> Expect.equal "you are all _ aren't you?"
         , test "Regex.split with never and empty string returns empty string" <| \{} ->
             Regex.split Regex.never ""
                 |> Expect.equal [""]
@@ -33,3 +36,9 @@ vowels : Regex
 vowels = 
     Regex.fromString "[aeiou]"
         |> Maybe.withDefault Regex.never
+
+
+smily : Regex
+smily = 
+    Regex.fromString "[🙂]"
+        |> Maybe.withDefault Regex.never