Add comment on upload cancellation during processing

ryanclark · web-flow · commit bb5617beecb1 · 2025-10-17T11:38:14.000+02:00
diff --git a/lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata.go b/lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata.go
@@ -128,6 +128,8 @@ func (s *RecordingMetadataService) ProcessSessionRecording(ctx context.Context,
 		})
 	}
 
+	// an upload will be cancelled if there is an error during processing, so we don't
+	// leave incomplete files behind
 	w, cancelUpload, uploadErrs := s.startUpload(ctx, sessionID)
 	shouldCancelUpload := true
 

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,8 @@ func (s *RecordingMetadataService) ProcessSessionRecording(ctx context.Context,`
`128`	`128`	`})`
`129`	`129`	`}`
`130`	`130`
	`131`	`+ // an upload will be cancelled if there is an error during processing, so we don't`
	`132`	`+ // leave incomplete files behind`
`131`	`133`	`w, cancelUpload, uploadErrs := s.startUpload(ctx, sessionID)`
`132`	`134`	`shouldCancelUpload := true`
`133`	`135`