Skip to content

Commit b4fa065

Browse files
LegNeatotheduke
authored andcommitted
Fix TODO for return type
We have bumped past the point of this TODO so we can make the changes.
1 parent 6562440 commit b4fa065

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

juniper/src/value/object.rs

+2-10
Original file line numberDiff line numberDiff line change
@@ -49,22 +49,14 @@ impl<S> Object<S> {
4949
}
5050

5151
/// Get a iterator over all field value pairs
52-
///
53-
/// This method returns a iterator over `&'a (String, Value)`
54-
// TODO: change this to `-> impl Iterator<Item = &(String, Value)>`
55-
// as soon as juniper bumps the minimal supported rust verion to 1.26
56-
pub fn iter(&self) -> FieldIter<S> {
52+
pub fn iter(&self) -> impl Iterator<Item = &(String, Value<S>)> {
5753
FieldIter {
5854
inner: self.key_value_list.iter(),
5955
}
6056
}
6157

6258
/// Get a iterator over all mutable field value pairs
63-
///
64-
/// This method returns a iterator over `&mut 'a (String, Value)`
65-
// TODO: change this to `-> impl Iterator<Item = &mut (String, Value)>`
66-
// as soon as juniper bumps the minimal supported rust verion to 1.26
67-
pub fn iter_mut(&mut self) -> FieldIterMut<S> {
59+
pub fn iter_mut(&mut self) -> impl Iterator<Item = &mut (String, Value<S>)> {
6860
FieldIterMut {
6961
inner: self.key_value_list.iter_mut(),
7062
}

0 commit comments

Comments
 (0)