Skip to content

onResult hook for _all_ operation results (including parsing and validation errors) #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enisdenjo opened this issue Aug 18, 2022 · 1 comment
Assignees

Comments

@enisdenjo
Copy link
Member

Currently, the onExecute and onExecuteDone hooks are invoked exclusively if execution occurs. If errors happen beforehand (like with parsing or validation issues), onExecute will not be invoked and the final result cannot be manipulated.

Introduce a new onResult hook allowing manipulation of the final result regardless of what happened.

Necessary for #1490

@enisdenjo
Copy link
Member Author

Actually, due to the envelop relying on the user to construct the final result on parsing and validation errors, this hook cannot be implemented.

We'd need an ultimate "parse, validate and execute/subscribe" function (accompanied with an appropriate hook) to achieve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant