measure some things (#7093)

Author: n1ru4l

packages/services/api/src/modules/operations/providers/operations-manager.ts

@@ -1,6 +1,7 @@
 import DataLoader from 'dataloader';
 import { Injectable, Scope } from 'graphql-modules';
 import LRU from 'lru-cache';
+import { traceFn } from '@hive/service-common';
 import type { DateRange } from '../../../shared/entities';
 import type { Listify, Optional } from '../../../shared/helpers';
 import { cache } from '../../../shared/helpers';
@@ -1099,6 +1100,13 @@ export class OperationsManager {
       period: DateRange;
     } & TargetSelector
   >(selector => JSON.stringify(selector))
+  @traceFn('OperationManager.countCoordinatesOfTarget', {
+    initAttributes: input => ({
+      'hive.organization.id': input.organizationId,
+      'hive.project.id': input.projectId,
+      'hive.target.id': input.targetId,
+    }),
+  })
   async countCoordinatesOfTarget({
     period,
     targetId: target,

packages/services/api/src/modules/operations/providers/operations-reader.ts

@@ -2,6 +2,7 @@ import { addMinutes, format } from 'date-fns';
 import { Injectable } from 'graphql-modules';
 import * as z from 'zod';
 import { UTCDate } from '@date-fns/utc';
+import { traceFn } from '@hive/service-common';
 import type { DateRange } from '../../../shared/entities';
 import { batch, batchBy } from '../../../shared/helpers';
 import { Logger } from '../../shared/providers/logger';
@@ -2124,6 +2125,11 @@ export class OperationsReader {
     }));
   }
 
+  @traceFn('OperationReader.countCoordinatesOfTarget', {
+    initAttributes: input => ({
+      'hive.target.id': input.target,
+    }),
+  })
   async countCoordinatesOfTarget({ target, period }: { target: string; period: DateRange }) {
     this.logger.debug('Count coordinates of target. (targetId=%s, period=%o)', target, period);
 

packages/services/api/src/modules/schema/utils.ts

@@ -13,62 +13,98 @@ import {
 } from './module.graphql.mappers';
 import stringify from 'fast-json-stable-stringify';
 import { ConstDirectiveNode, DEFAULT_DEPRECATION_REASON, DocumentNode, Kind, print } from 'graphql';
+import { traceInlineSync } from '@hive/service-common';
 import type { DateRange } from '../../shared/entities';
 import type { PromiseOrValue } from '../../shared/helpers';
 import { OperationsManager } from '../operations/providers/operations-manager';
 import { TargetSelector } from '../shared/providers/storage';
 import { SuperGraphInformation } from './lib/federation-super-graph';
 
-export function withUsedByClients<
-  T extends {
-    isUsed: boolean;
-  },
->(
-  input: Record<string, T>,
-  deps: {
-    operationsManager: OperationsManager;
-    selector: TargetSelector;
-    period: DateRange;
-    typename: string;
-  },
-): Record<
-  string,
-  T & {
-    usedByClients: () => PromiseOrValue<Array<string>>;
-    period: DateRange;
-    organizationId: string;
-    projectId: string;
-    targetId: string;
-    typename: string;
-  }
-> {
-  return Object.fromEntries(
-    Object.entries(input).map(([schemaCoordinate, record]) => [
-      schemaCoordinate,
-      {
-        selector: deps.selector,
-        period: deps.period,
-        typename: deps.typename,
-        organizationId: deps.selector.organizationId,
-        projectId: deps.selector.projectId,
-        targetId: deps.selector.targetId,
-        ...record,
-        usedByClients() {
-          if (record.isUsed === false) {
-            return [];
-          }
+export const withUsedByClients = traceInlineSync(
+  'withUsedByClients',
+  {},
+  function withUsedByClients<
+    T extends {
+      isUsed: boolean;
+    },
+  >(
+    input: Record<string, T>,
+    deps: {
+      operationsManager: OperationsManager;
+      selector: TargetSelector;
+      period: DateRange;
+      typename: string;
+    },
+  ): Record<
+    string,
+    T & {
+      usedByClients: () => PromiseOrValue<Array<string>>;
+      period: DateRange;
+      organizationId: string;
+      projectId: string;
+      targetId: string;
+      typename: string;
+    }
+  > {
+    // input can contain ALLLLLLLLLL the schema coordinates.
+    // in order to be more efficient we lazily create the properties here as we could accidentially create way tooo much stuff!
+    return new Proxy(input, {
+      get(target, property, receiver) {
+        if (
+          typeof property !== 'string' ||
+          /** some code might check if this is a promise :D */
+          property === 'then'
+        ) {
+          return Reflect.get(target, property, receiver);
+        }
 
-          // It's using DataLoader under the hood so it's safe to call it multiple times for different coordinates
-          return deps.operationsManager.getClientNamesPerCoordinateOfType({
-            ...deps.selector,
-            period: deps.period,
-            schemaCoordinate,
-          });
-        },
+        // Guard against trying to look up properties that do not belong to this typename!
+        if (!property.startsWith(deps.typename)) {
+          return undefined;
+        }
+
+        const schemaCoordinate = property;
+        const record = input[property];
+
+        if (!record) {
+          return undefined;
+        }
+
+        return {
+          selector: deps.selector,
+          period: deps.period,
+          typename: deps.typename,
+          organizationId: deps.selector.organizationId,
+          projectId: deps.selector.projectId,
+          targetId: deps.selector.targetId,
+          ...record,
+          usedByClients() {
+            if (record.isUsed === false) {
+              return [];
+            }
+
+            // It's using DataLoader under the hood so it's safe to call it multiple times for different coordinates
+            return deps.operationsManager.getClientNamesPerCoordinateOfType({
+              ...deps.selector,
+              period: deps.period,
+              schemaCoordinate,
+            });
+          },
+        };
       },
-    ]),
-  );
-}
+    }) as Record<
+      string,
+      T & {
+        usedByClients: () => PromiseOrValue<Array<string>>;
+        period: DateRange;
+        organizationId: string;
+        projectId: string;
+        targetId: string;
+        typename: string;
+      }
+    >;
+  },
+);
 
 function deprecationReasonFromDirectives(directives: readonly ConstDirectiveNode[] | undefined) {
   if (!directives) {

packages/services/service-common/src/tracing.ts

@@ -473,8 +473,8 @@ export function traceFn<This extends Object, TArgs extends any[], TResult>(
   options?: FunctionTraceOptions<TArgs, Awaited<TResult>>,
 ) {
   return function (
-    target: This,
-    key: PropertyKey,
+    _target: This,
+    _key: PropertyKey,
     descriptor: TypedPropertyDescriptor<(...args: TArgs) => TResult>,
   ) {
     const originalMethod = descriptor.value;