Skip to content

Commit 7fa1f73

Browse files
committed
Simplified listValue classes
1 parent 31ce2e6 commit 7fa1f73

3 files changed

Lines changed: 6 additions & 52 deletions

File tree

src/Value/ListInputedValue.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ public function getRawValue(bool $forResolvers = false) : array
2323
return $return;
2424
}
2525

26-
#[\Override]
27-
public function getType() : ListType
28-
{
29-
return $this->type;
30-
}
31-
3226
#[\Override]
3327
public function printValue() : string
3428
{

src/Value/ListResolvedValue.php

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,28 +4,12 @@
44

55
namespace Graphpinator\Value;
66

7-
use Graphpinator\Typesystem\ListType;
8-
97
final class ListResolvedValue extends ListValue implements OutputValue
108
{
119
#[\Override]
1210
public function getRawValue() : array
1311
{
14-
$return = [];
15-
16-
foreach ($this->value as $listItem) {
17-
\assert($listItem instanceof ResolvedValue);
18-
19-
$return[] = $listItem->getRawValue();
20-
}
21-
22-
return $return;
23-
}
24-
25-
#[\Override]
26-
public function getType() : ListType
27-
{
28-
return $this->type;
12+
return $this->value;
2913
}
3014

3115
#[\Override]

src/Value/ListValue.php

Lines changed: 5 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
use Graphpinator\Typesystem\ListType;
88

9-
abstract class ListValue implements Value, \IteratorAggregate, \ArrayAccess, \Countable
9+
abstract class ListValue implements Value, \IteratorAggregate
1010
{
1111
public function __construct(
1212
protected ListType $type,
@@ -16,38 +16,14 @@ public function __construct(
1616
}
1717

1818
#[\Override]
19-
public function getIterator() : \ArrayIterator
20-
{
21-
return new \ArrayIterator($this->value);
22-
}
23-
24-
#[\Override]
25-
public function count() : int
26-
{
27-
return \count($this->value);
28-
}
29-
30-
#[\Override]
31-
public function offsetExists($offset) : bool
19+
public function getType() : ListType
3220
{
33-
return \array_key_exists($offset, $this->value);
21+
return $this->type;
3422
}
3523

3624
#[\Override]
37-
public function offsetGet($offset) : Value
38-
{
39-
return $this->value[$offset];
40-
}
41-
42-
#[\Override]
43-
public function offsetSet($offset, $value) : void
44-
{
45-
$this->value[$offset] = $value;
46-
}
47-
48-
#[\Override]
49-
public function offsetUnset($offset) : void
25+
public function getIterator() : \ArrayIterator
5026
{
51-
unset($this->value[$offset]);
27+
return new \ArrayIterator($this->value);
5228
}
5329
}

0 commit comments

Comments
 (0)