-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subgraph/cluster and class count #42
Comments
@clue hello. |
@llaville Thanks for reporting, it looks like you've spotted a missing feature / a minor bug! I agree that we should draw a subgraph if only one group has been assigned explicitly. On top of this, we should not draw a subgraph if only one group has been assigned implicitly (all vertices are in the Adding this shouldn't be too hard. I'll take a look at this again before the next release is tagged, PRs are very welcome in case anybody beats me to it 👍 |
@clue Here is the final patch I used with cweagans/composer-patches to modify your package on installation to add this new feature !
|
This project seems unmaintained, and I'm not sure to want to keep a fork with patch. Perharps I'll create a new standalone project in future days to replace it. |
@llaville This project is indeed maintained, @clue and I have over 100 open source projects to look over here on GitHub and we're currently a lot involved in working on ReactPHP. Even if we're currently not actively working on new features in this project doesn't mean we're not reviewing any suggestions made by contributors. If you need this urgently, you can also reach out to us or help us by becoming as sponsor If you would like to add this new feature to the project you can also open up a pull request, just add the necessary tests to assure everything works as expected and we're happy to take a look 👍 |
Hello,
i'm currently working on a PHP solution based on your packages (here are my versions used)
I've recently be aware that when there are many classes in a diagram, subgraph even with a single class, are displayed correctly.
But when there is only one namespace and one class, such as :
subgraph is not generated and give such result :
Statements code corresponding to this image are :
While I'm expected to see the rectangle that show the namespace as follow
Statements code corresponding to this image are :
To produce such result, i've just changed one line in your code : https://github.com/graphp/graphviz/blob/master/src/GraphViz.php#L283
Tell me what you think, and if you're agree with this change !
Thanks
Laurent
The text was updated successfully, but these errors were encountered: