Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest version of graphp/graph #53

Open
jrmgx opened this issue Mar 27, 2024 · 1 comment
Open

Support latest version of graphp/graph #53

jrmgx opened this issue Mar 27, 2024 · 1 comment

Comments

@jrmgx
Copy link

jrmgx commented Mar 27, 2024

The https://github.com/graphp/graph package has a version 0.9 and 1.x, and they seem incompatible with the latest version of this one (graphp/algorithms)

Is there a plan?

What is the recommended way to go?

Thank you

@SimonFrings SimonFrings changed the title Support new version of graphp/graph lib? Support latest version of graphp/graph Apr 18, 2024
@SimonFrings
Copy link
Contributor

Hey @jrmgx, thanks for bringing this up 👍

I took a closer look at this and yes, the current version of graphp/algorithms is not compatible with the latest version of graphp/graph. We never opened a specific ticket for this (so good that this is being addressed).

The installation for graphp/graph library was locked in a specific commit in #41. This library went through some massive changes afterwards, which we're currently not compatible with. The Algorithms API itself also needs some major remodeling, as @clue described in #5 and other tickets.

As you can see, creating compatibility involves a good amount of work and we'll have a look at this when time allows it (currently working a lot on ReactPHP and Framework X). We're always happy about contributions for this, but I don't think this will be an easy pick as it involves API changes, test improvements, documentation changes, etc. (still happy if someone wants to give it a try).

If you need compatibility with the latest version of graphp/graph urgently, you can always reach out to us or help us prioritizing by becoming a sponsor ❤️

Hope this gives some insights 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants