feat: symbolize only otel-related profiles

Author: marcsanmi

pkg/experiment/ingester/segment.go

@@ -520,21 +520,6 @@ func (s *segment) ingest(tenantID string, p *profilev1.Profile, id uuid.UUID, la
 	// CountReceivedBytes is tracked in distributors.
 }
 
-func hasSymbols(p *profilev1.Profile) bool {
-	if p == nil || len(p.Function) == 0 || len(p.Location) == 0 {
-		return false
-	}
-
-	for _, loc := range p.Location {
-		if len(loc.Line) == 0 {
-			// If any location lacks symbols, the profile needs symbolization
-			return false
-		}
-	}
-
-	return true
-}
-
 // getFunctionById returns a function by its ID
 func getFunctionById(p *profilev1.Profile, id uint64) (*profilev1.Function, bool) {
 	for _, fn := range p.Function {

pkg/frontend/read_path/query_frontend/query_frontend.go

@@ -142,24 +142,28 @@ func (q *QueryFrontend) Query(
 					continue
 				}
 
-				if err := q.symbolizer.SymbolizePprof(ctx, &prof); err != nil {
-					level.Error(q.logger).Log("msg", "symbolize pprof", "err", err)
-				}
-
-				// Convert back to tree if originally a tree
-				if i < len(req.Query) && req.Query[i].QueryType == queryv1.QueryType_QUERY_TREE {
-					if len(prof.SampleType) > 1 {
-						return nil, fmt.Errorf("multiple sample types not supported")
+				// TODO: check if whether it comes from OTEL!
+				isOTEL := isProfileFromOTEL(&prof)
+				if isOTEL {
+					if err := q.symbolizer.SymbolizePprof(ctx, &prof); err != nil {
+						level.Error(q.logger).Log("msg", "symbolize pprof", "err", err)
 					}
-					treeBytes := model.TreeFromBackendProfile(&prof, req.Query[i].Tree.MaxNodes)
-					// Store the tree result
-					r.Tree = &queryv1.TreeReport{Tree: treeBytes}
-					r.ReportType = queryv1.ReportType_REPORT_TREE
-					r.Pprof = nil
-				} else {
-					symbolizedBytes, err := pprof.Marshal(&prof, true)
-					if err == nil {
-						r.Pprof.Pprof = symbolizedBytes
+
+					// Convert back to tree if originally a tree
+					if i < len(req.Query) && req.Query[i].QueryType == queryv1.QueryType_QUERY_TREE {
+						if len(prof.SampleType) > 1 {
+							return nil, fmt.Errorf("multiple sample types not supported")
+						}
+						treeBytes := model.TreeFromBackendProfile(&prof, req.Query[i].Tree.MaxNodes)
+						// Store the tree result
+						r.Tree = &queryv1.TreeReport{Tree: treeBytes}
+						r.ReportType = queryv1.ReportType_REPORT_TREE
+						r.Pprof = nil
+					} else {
+						symbolizedBytes, err := pprof.Marshal(&prof, true)
+						if err == nil {
+							r.Pprof.Pprof = symbolizedBytes
+						}
 					}
 				}
 			}
@@ -238,3 +242,18 @@ func (q *QueryFrontend) hasNativeProfiles(block *metastorev1.BlockMeta) bool {
 
 	return hasNativeProfiles
 }
+
+func isProfileFromOTEL(prof *profilev1.Profile) bool {
+	// Check sample labels
+	for _, sample := range prof.Sample {
+		for _, label := range sample.Label {
+			// Get the key and value from string table
+			keyStr := prof.StringTable[label.Key]
+			valStr := prof.StringTable[label.Str]
+			if keyStr == phlaremodel.LabelNameOTEL && valStr == "true" {
+				return true
+			}
+		}
+	}
+	return false
+}

pkg/frontend/read_path/query_frontend/query_frontend_test.go

@@ -24,7 +24,7 @@ func Test_QueryFrontend_QueryMetadata(t *testing.T) {
 			request: &metastorev1.QueryMetadataRequest{
 				TenantId: []string{"org"},
 				Query:    `{service_name="service-a"}`,
-				Labels:   []string{"__needs_symbolization__"},
+				Labels:   []string{"__has_native_profiles__"},
 			},
 			response: &metastorev1.QueryMetadataResponse{
 				Blocks: []*metastorev1.BlockMeta{{Id: "block_id_a"}},
@@ -35,7 +35,7 @@ func Test_QueryFrontend_QueryMetadata(t *testing.T) {
 			request: &metastorev1.QueryMetadataRequest{
 				TenantId: []string{"org"},
 				Query:    `{__tenant_dataset__="dataset_tsdb_index"}`,
-				Labels:   []string{"__needs_symbolization__", "__tenant_dataset__"},
+				Labels:   []string{"__has_native_profiles__", "__tenant_dataset__"},
 			},
 			response: &metastorev1.QueryMetadataResponse{
 				Blocks: []*metastorev1.BlockMeta{{Id: "block_id_a"}},
@@ -46,7 +46,7 @@ func Test_QueryFrontend_QueryMetadata(t *testing.T) {
 			request: &metastorev1.QueryMetadataRequest{
 				TenantId: []string{"org"},
 				Query:    `{__tenant_dataset__="dataset_tsdb_index"}`,
-				Labels:   []string{"__needs_symbolization__", "__tenant_dataset__"},
+				Labels:   []string{"__has_native_profiles__", "__tenant_dataset__"},
 			},
 			response: &metastorev1.QueryMetadataResponse{
 				Blocks: []*metastorev1.BlockMeta{{Id: "block_id_c"}},
@@ -57,7 +57,7 @@ func Test_QueryFrontend_QueryMetadata(t *testing.T) {
 			request: &metastorev1.QueryMetadataRequest{
 				TenantId: []string{"org"},
 				Query:    `{__tenant_dataset__="dataset_tsdb_index"}`,
-				Labels:   []string{"__needs_symbolization__", "__tenant_dataset__"},
+				Labels:   []string{"__has_native_profiles__", "__tenant_dataset__"},
 			},
 			response: &metastorev1.QueryMetadataResponse{
 				Blocks: []*metastorev1.BlockMeta{{Id: "block_id_b"}},
@@ -68,7 +68,7 @@ func Test_QueryFrontend_QueryMetadata(t *testing.T) {
 			request: &metastorev1.QueryMetadataRequest{
 				TenantId: []string{"org"},
 				Query:    `{__tenant_dataset__="dataset_tsdb_index"}`,
-				Labels:   []string{"__needs_symbolization__", "__tenant_dataset__"},
+				Labels:   []string{"__has_native_profiles__", "__tenant_dataset__"},
 			},
 			response: &metastorev1.QueryMetadataResponse{
 				Blocks: []*metastorev1.BlockMeta{{Id: "block_id_d"}},