Skip to content

Commit 1c8d6bd

Browse files
korniltsevsimonswine
korniltsev
and
simonswine
authored
[release/v1.12] Update golang version to 1.23.8 (#4115)
Backport b0a4a4f from #4106 Backport #3996 Backport #4019 * Update golang version to 1.23.8 * manually update examples go.work to go 1.23.0 * Remove doc-validator (#3996) * chore: Remove qemu ebpf tests (#4019) They are failing since some time and we are planning to migrate to ebpf-profiler from open-telemetry. --------- Co-authored-by: Christian Simon <[email protected]>
1 parent 19d09d6 commit 1c8d6bd

File tree

34 files changed

+30
-133
lines changed

34 files changed

+30
-133
lines changed

‎.github/workflows/e2e.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: Install Go
2626
uses: actions/setup-go@v5
2727
with:
28-
go-version: "1.23.7"
28+
go-version: "1.23.8"
2929
cache: true
3030
- run: yarn --frozen-lockfile
3131
- run: make build
@@ -55,7 +55,7 @@ jobs:
5555
- name: Install Go
5656
uses: actions/setup-go@v5
5757
with:
58-
go-version: "1.23.7"
58+
go-version: "1.23.8"
5959
cache: true
6060
- run: yarn --frozen-lockfile
6161
- run: make build

‎.github/workflows/fuzzer.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ jobs:
1313
- name: Install Go
1414
uses: actions/setup-go@v5
1515
with:
16-
go-version: 1.23.7
16+
go-version: 1.23.8
1717
- name: Run Fuzz_Merge_Single
1818
run: go test -fuzz=Fuzz_Merge_Single --fuzztime 1h -run '^$' -v ./pkg/pprof/

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- run: git fetch --force --tags
2929
- uses: actions/setup-go@v5
3030
with:
31-
go-version: "1.23.7"
31+
go-version: "1.23.8"
3232
cache: true
3333
- uses: actions/setup-node@v3
3434
with:

‎.github/workflows/test-examples.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ jobs:
2020
- name: Install Go
2121
uses: actions/setup-go@v5
2222
with:
23-
go-version: 1.23.7
23+
go-version: 1.23.8
2424
- name: Run tests
2525
run: make examples/test

‎.github/workflows/test.yml‎

Lines changed: 6 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Install Go
2323
uses: actions/setup-go@v5
2424
with:
25-
go-version: 1.23.7
25+
go-version: 1.23.8
2626
- name: Format
2727
run: make fmt check/unstaged-changes
2828
check-generated:
@@ -33,7 +33,7 @@ jobs:
3333
- name: Install Go
3434
uses: actions/setup-go@v5
3535
with:
36-
go-version: 1.23.7
36+
go-version: 1.23.8
3737
- name: Check generated files
3838
run: make generate check/unstaged-changes
3939
test:
@@ -44,7 +44,7 @@ jobs:
4444
- name: Install Go
4545
uses: actions/setup-go@v5
4646
with:
47-
go-version: 1.23.7
47+
go-version: 1.23.8
4848
- name: Go Mod
4949
run: make check/go/mod
5050
- name: Test
@@ -57,7 +57,7 @@ jobs:
5757
- name: Install Go
5858
uses: actions/setup-go@v5
5959
with:
60-
go-version: 1.23.7
60+
go-version: 1.23.8
6161
- name: Run linter
6262
run: make lint
6363
- name: Check helm manifests
@@ -71,28 +71,6 @@ jobs:
7171
- name: "Test docs"
7272
run: make docs/test
7373

74-
doc-validator:
75-
runs-on: "ubuntu-latest"
76-
container:
77-
image: "grafana/doc-validator:v5.2.0"
78-
steps:
79-
- name: "Checkout code"
80-
uses: "actions/checkout@v4"
81-
- name: "Run doc-validator tool"
82-
run: >
83-
doc-validator
84-
'--skip-checks=^image.+$'
85-
docs/sources
86-
/docs/writers-toolkit
87-
| reviewdog
88-
-f=rdjsonl
89-
--fail-on-error
90-
--filter-mode=nofilter
91-
--name=doc-validator
92-
--reporter=github-pr-review
93-
env:
94-
REVIEWDOG_GITHUB_API_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
95-
9674
build-image:
9775
if: github.event_name != 'push'
9876
runs-on: ubuntu-latest
@@ -107,7 +85,7 @@ jobs:
10785
- name: Set up go
10886
uses: actions/setup-go@v5
10987
with:
110-
go-version: 1.23.7
88+
go-version: 1.23.8
11189
- uses: actions/setup-node@v3
11290
with:
11391
node-version: 20
@@ -129,7 +107,7 @@ jobs:
129107
- name: Set up go
130108
uses: actions/setup-go@v5
131109
with:
132-
go-version: 1.23.7
110+
go-version: 1.23.8
133111
- uses: actions/setup-node@v3
134112
with:
135113
node-version: lts/hydrogen

‎.github/workflows/test_ebpf.yml‎

Lines changed: 1 addition & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -27,77 +27,6 @@ jobs:
2727
- name: Install Go
2828
uses: actions/setup-go@v5
2929
with:
30-
go-version: 1.23.7
30+
go-version: 1.23.8
3131
- name: Test
3232
run: sudo make -C ./ebpf go/test/amd64
33-
test_ebpf_qemu:
34-
name: on QEMU
35-
runs-on: ubuntu-latest-16-cores
36-
strategy:
37-
matrix:
38-
include:
39-
# - arch: amd64 # https://github.com/grafana/pyroscope/issues/3033
40-
# kernel: amd64/boot/vmlinuz-4.19.0-26-amd64
41-
# initrd: amd64/boot/initrd.img-4.19.0-26-amd64
42-
- arch: amd64
43-
kernel: amd64/boot/vmlinuz-5.10.0-28-amd64
44-
initrd: amd64/boot/initrd.img-5.10.0-28-amd64
45-
- arch: amd64
46-
kernel: amd64/boot/vmlinuz-5.15.0-94-generic
47-
initrd: amd64/boot/initrd.img-5.15.0-94-generic
48-
- arch: amd64
49-
kernel: amd64/boot/vmlinuz-5.4.0-150-generic
50-
initrd: amd64/boot/initrd.img-5.4.0-150-generic
51-
- arch: amd64
52-
kernel: amd64/boot/vmlinuz-6.1.0-18-amd64
53-
initrd: amd64/boot/initrd.img-6.1.0-18-amd64
54-
- arch: amd64
55-
kernel: amd64/boot_extra/vmlinuz-5.10.205-195.807.amzn2.x86_64
56-
initrd: amd64/boot_extra/initramfs-5.10.205-195.807.amzn2.x86_64.img
57-
58-
# - arch: arm64 # https://github.com/grafana/pyroscope/issues/3033
59-
# kernel: arm64/boot/vmlinuz-4.19.0-26-arm64
60-
# initrd: arm64/boot/initrd.img-4.19.0-26-arm64
61-
- arch: arm64
62-
kernel: arm64/boot/vmlinuz-5.10.0-28-arm64
63-
initrd: arm64/boot/initrd.img-5.10.0-28-arm64
64-
- arch: arm64
65-
kernel: arm64/boot/vmlinuz-5.15.0-94-generic
66-
initrd: arm64/boot/initrd.img-5.15.0-94-generic
67-
- arch: arm64
68-
kernel: arm64/boot/vmlinuz-5.4.0-150-generic
69-
initrd: arm64/boot/initrd.img-5.4.0-150-generic
70-
- arch: arm64
71-
kernel: arm64/boot/vmlinuz-6.1.0-18-arm64
72-
initrd: arm64/boot/initrd.img-6.1.0-18-arm64
73-
- arch: arm64
74-
kernel: arm64/boot_extra/vmlinuz-5.10.205-195.807.amzn2.aarch64
75-
initrd: arm64/boot_extra/initramfs-5.10.205-195.807.amzn2.aarch64.img
76-
77-
steps:
78-
- name: Checkout code with submodule
79-
uses: actions/checkout@v4
80-
with:
81-
submodules: recursive
82-
- name: Install Go
83-
uses: actions/setup-go@v5
84-
with:
85-
go-version: 1.23.7
86-
- name: Install qemu
87-
run: sudo apt-get update && sudo apt-get -y install qemu-system-x86 qemu-system-aarch64
88-
- name: Build tests
89-
run: make -C ./ebpf ebpf.${{ matrix.arch }}.test
90-
- name: Pull VM image
91-
run: make -C ./ebpf/testdata/qemu_img dist/pull
92-
- name: Start VM
93-
run: >
94-
KVM_ARGS="" ARCH=${{ matrix.arch }} KERNEL=${{ matrix.kernel }} INITRD=${{ matrix.initrd }} make -C ./ebpf/testdata/qemu_img qemu/start_and_wait
95-
- name: Copy test binary
96-
run: >
97-
F=$(realpath ./ebpf/ebpf.${{ matrix.arch }}.test) make -C ./ebpf/testdata/qemu_img qemu/scp
98-
- name: Uname
99-
run: >
100-
CMD="uname -a" make -C ./ebpf/testdata/qemu_img qemu/exec
101-
- name: Run tests
102-
run: >
103-
CMD=./ebpf.${{ matrix.arch }}.test make -C ./ebpf/testdata/qemu_img qemu/exec

‎.github/workflows/weekly-release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
git tag "$WEEKLY_IMAGE_TAG"
2828
- uses: actions/setup-go@v5
2929
with:
30-
go-version: "1.23.7"
30+
go-version: "1.23.8"
3131
cache: true
3232
# setup docker buildx
3333
- name: Set up QEMU

‎.goreleaser.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: 2
33
before:
44
hooks:
55
# This hook ensures that goreleaser uses the correct go version for a Pyroscope release
6-
- sh -euc 'go version | grep "go version go1.23.7 " || { echo "Unexpected go version"; exit 1; }'
6+
- sh -euc 'go version | grep "go version go1.23.8 " || { echo "Unexpected go version"; exit 1; }'
77
env:
88
# Strip debug information from the binary by default, weekly builds will have debug information
99
- GORELEASER_DEBUG_INFO_FLAGS={{ if and (index .Env "GORELEASER_STRIP_DEBUG_INFO") (eq .Env.GORELEASER_STRIP_DEBUG_INFO "false") }}{{ else }}-s -w{{ end }}

‎api/go.mod‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ module github.com/grafana/pyroscope/api
22

33
go 1.23.0
44

5-
65
require (
76
connectrpc.com/connect v1.16.2
87
github.com/gogo/protobuf v1.3.2

‎ebpf/go.mod‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ module github.com/grafana/pyroscope/ebpf
22

33
go 1.23.0
44

5-
65
require (
76
connectrpc.com/connect v1.16.2
87
github.com/avvmoto/buf-readerat v0.0.0-20171115124131-a17c8cb89270

0 commit comments

Comments
 (0)