Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

databaseOptions optimization #5384

Open
marunrun opened this issue Dec 25, 2024 · 1 comment · May be fixed by #5385
Open

databaseOptions optimization #5384

marunrun opened this issue Dec 25, 2024 · 1 comment · May be fixed by #5385
Labels
feature request New feature or request more info needed needs triage part:helm/kubernetes/docker

Comments

@marunrun
Copy link

What would you like to see!

to resolve the djiango-mysql-w200-innodb-strict-mode

i need to add init_command=SET innodb_strict_mode=1 options , but I cannot achieve it by setting the environment variables.

oncall/engine/settings/base.py

Lines 155 to 162 in cc63ec3

DATABASE_OPTIONS = os.getenv("DATABASE_OPTIONS")
if DATABASE_OPTIONS:
try:
DATABASE_OPTIONS = dict([tuple(i.split("=")) for i in str(DATABASE_OPTIONS).split(" ")])
except Exception:
raise Exception("Bad database options. Check DATABASE_OPTIONS variable")
else:
DATABASE_OPTIONS = {}

It was scattered, as shown in the following figure.

Image

by the way , the helm templates MYSQL_OPTIONS is wrong.

oncall/helm/oncall/templates/_env.tpl

Lines 246 to 251 in cc63ec3

{{- with .Values.externalMysql.options }}
- name: MYSQL_OPTIONS
value: {{ . | quote }}
{{- end }}
{{- end }}
{{- end }}

Product Area

Other, Helm/Kubernetes/Docker

Anything else to add?

No response
@marunrun marunrun added the feature request New feature or request label Dec 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

The current version of Grafana OnCall, at the time this issue was opened, is v1.13.11. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@marunrun marunrun linked a pull request Dec 25, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request more info needed needs triage part:helm/kubernetes/docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(settings): Repair database option parsing logic marunrun/oncall
1 participant
@marunrun