Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Comment out metric_aggregation_enabled and metric_aggregation due to issue in Loki 3.1.2 #15568

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hoonyworld
Copy link

What this PR does / why we need it:
This PR comments out the metric_aggregation_enabled and metric_aggregation options in the loki-local-config.yaml file, as these configurations are not supported in Loki 3.1.2 and cause a parsing error when used.

Which issue(s) this PR fixes:
Fixes #15567

Special notes for your reviewer:

The commented-out configurations align the example configuration file with the behavior of Loki 3.1.2 to prevent confusion and errors for users attempting to use unsupported settings.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@hoonyworld hoonyworld requested a review from a team as a code owner December 31, 2024 11:13
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metric_aggregation_enabled and metric_aggregation settings do not work in Loki 3.1.2
2 participants