Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete documentation for read.legacyReadTarget and read.persistence #15550

Open
peske opened this issue Dec 26, 2024 · 1 comment
Open

Incomplete documentation for read.legacyReadTarget and read.persistence #15550

peske opened this issue Dec 26, 2024 · 1 comment

Comments

@peske
Copy link

peske commented Dec 26, 2024

Is your feature request related to a problem? Please describe.
After installing grafana/loki chart in SSD mode, I've noticed that read node doesn't create/use PVCs. After analyzing the source code of the chart, I've concluded that read.persistence is used only if read.legacyReadTarget is set to true. The problem is that this isn't mentioned in the values file, and took me time to prepare unnecessary PVs.

Describe the solution you'd like
Just put line like following before read.persistence:

# Used only if legacyReadTarget is set to true

Describe alternatives you've considered
None

Additional context
Related to grafana/loki chart.

@duj4
Copy link

duj4 commented Dec 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants