Skip to content

Allow GPUTexture where GPUTextureView is used #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2025
Merged

Allow GPUTexture where GPUTextureView is used #4407

merged 4 commits into from
Jul 9, 2025

Conversation

@beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Jun 24, 2025

Spec PR: gpuweb/gpuweb#5228

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.) They pass in a Chromium build patched with https://chromium-review.googlesource.com/c/chromium/src/+/6656722
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@beaufortfrancois beaufortfrancois marked this pull request as draft June 24, 2025 13:04
greggman
greggman requested changes Jun 25, 2025
View reviewed changes
@beaufortfrancois beaufortfrancois force-pushed the use-texture branch 2 times, most recently from 3f4bf23 to a4b0960 Compare June 25, 2025 14:12
@beaufortfrancois beaufortfrancois marked this pull request as ready for review July 4, 2025 06:15
@beaufortfrancois
Copy link
Collaborator Author

beaufortfrancois commented Jul 7, 2025

Note that I'll wait for gpuweb/types#186 to be merged.

@beaufortfrancois
Copy link
Collaborator Author

beaufortfrancois commented Jul 8, 2025

@greggman Do you think I shall update more tests for this feature or are we good with those validation tests?

@greggman
Copy link
Contributor

greggman commented Jul 8, 2025

I think it's fine with these tests

@beaufortfrancois beaufortfrancois merged commit 7d143a9 into main Jul 9, 2025
1 check passed
@beaufortfrancois beaufortfrancois deleted the use-texture branch July 9, 2025 12:28
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 11, 2025
@ErichDonGubler
Bug ??????? - feat(webgpu): allow GPUTextures where `GPUTextureView…
05d67ea 
…`s are allowed r=#webgpu-reviewers!

gpuweb/cts#4407

gpuweb/gpuweb#5228
@ErichDonGubler ErichDonGubler mentioned this pull request Jul 11, 2025
Closed
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 11, 2025
@ErichDonGubler
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
bc0a410 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 12, 2025
@ErichDonGubler
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
bbcdb1a 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 12, 2025
@ErichDonGubler
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
f060d1b 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 16, 2025
@ErichDonGubler
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
6dce345 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 16, 2025
@ErichDonGubler
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
b731ac3 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Jul 17, 2025
@ErichDonGubler
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
f635aec 
…`s are allowed r=webgpu-reviewers,webidl,smaug,nical

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
@beaufortfrancois beaufortfrancois mentioned this pull request Jul 17, 2025
Open
4 tasks
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Jul 21, 2025
@ErichDonGubler
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
bdc10b9 
…`s are allowed r=webgpu-reviewers,webidl,smaug,nical

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler added a commit to erichdongubler-mozilla/gpuweb-cts that referenced this pull request Aug 23, 2025
@ErichDonGubler
fix: properly apply bindTextureResource in `render_pass_descriptor:…
affe15a 
…one_*_attachment` tests

This is a bug in gpuweb#4407, where this coverage was originally intended to
be introduced.
@ErichDonGubler ErichDonGubler mentioned this pull request Aug 23, 2025
Merged
ErichDonGubler
ErichDonGubler reviewed Aug 23, 2025
View reviewed changes
src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts

g.test('attachments,one_color_attachment')
.desc(`Test that a render pass works with only one color attachment.`)
.paramsSubcasesOnly(u => u.combine('bindTextureResource', [false, true] as const))
Copy link
Member

@ErichDonGubler ErichDonGubler Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bindTextureResource is not actually being used in both of these one_*_attachment tests, so we're not actually exercising the GPUTexture case. Filed a fix in #4447.

ErichDonGubler added a commit to erichdongubler-mozilla/gpuweb-cts that referenced this pull request Aug 23, 2025
@ErichDonGubler
fix: properly apply bindTextureResource in `render_pass_descriptor:…
872797e 
…one_*_attachment` tests

This is a bug in gpuweb#4407, where this coverage was originally intended to
be introduced.
ErichDonGubler added a commit that referenced this pull request Aug 26, 2025
@ErichDonGubler
fix: properly apply bindTextureResource in `render_pass_descriptor:…
5a49f0b 
…one_*_attachment` tests (#4447)

This is a bug in #4407, where this coverage was originally intended to
be introduced.
greggman pushed a commit to greggman/cts that referenced this pull request Oct 14, 2025
@ErichDonGubler @greggman
fix: properly apply bindTextureResource in `render_pass_descriptor:…
58c5185 
…one_*_attachment` tests (gpuweb#4447)

This is a bug in gpuweb#4407, where this coverage was originally intended to
be introduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler left review comments

@greggman greggman greggman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@beaufortfrancois @greggman @ErichDonGubler