Refactor selectDeviceOrSkipTest system #4150
Merged
+52
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing system selected the device immediately which means
code like this
t.selectDeviceOrSkipTest('timestamp-query');
t.selectDeviceOrSkipTesT('float32-renderable'); // fail!
would fail on the 2nd line because a device had already been
requested on the first line.
Refactored so that the various requirements are merged and
only at the end is a device requested.
Tested here:
d4abf41
greggman
force-pushed
the
select-device-refactor
branch
from
26d7fe8 to
5c1714e
Compare
shrekshao
added a commit
to shrekshao/cts
that referenced
this pull request
Jan 17, 2025
shrekshao
added a commit
that referenced
this pull request
Jan 17, 2025
* Compat: fix float16(32)-renderable tests * revert configure change * Fix after #4150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing system selected the device immediately which means code like this
would fail on the 2nd line because a device had already been requested on the first line.
Refactored so that the various requirements are merged and only at the end is a device requested.
Tested here:
greggman@d4abf41