WebGPU devices are never destroyed? #784
Assignees
Comments
DDoS
pushed a commit
to faro-oss/Dawn
that referenced
this issue
Oct 20, 2021
These should always be resolved or rejected. The Fatal() call, when a promise is not resolved or rejected, is currently disabled due to gpuweb/cts#784. Bug: dawn:1123 Change-Id: Ie0e8ac187ad70be0fea41cd66956d0bfd9c53212 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/66821 Reviewed-by: Antonio Maiorano <[email protected]> Commit-Queue: Ben Clayton <[email protected]>
|
We're not, and that's because we didn't have device destruction until recently. (Actually I'm not even sure whether it's completed yet.) I have a draft of some tests for device destruction and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As far as I can tell, WebGPU devices are never destroyed. There's a TODO in
device_pool.tsfor destroying a device:cts/src/webgpu/util/device_pool.ts
Line 77 in 2ebec0e
If we're not destroying devices, we're not testing tear-down logic, which seems like a big thing to be missing right now.
It also seems that because we're not destroying the devices, the
Device.lostpromise will never be resolved or rejected.The text was updated successfully, but these errors were encountered: