From d574ce799198ec46dab9b34cce7f78c82a900b24 Mon Sep 17 00:00:00 2001
From: James Price <jrprice@google.com>
Date: Tue, 27 Feb 2024 14:12:51 -0500
Subject: [PATCH] wgsl: Add workgroupUniformLoad validation tests (#3429)

Test that the builtin can only be used from compute shaders and that
atomic types are not allowed.

The execution tests cover a variety of valid types, so that is not
tested here
---
 src/webgpu/listing_meta.json                  |   2 +
 .../call/builtin/workgroupUniformLoad.spec.ts | 122 ++++++++++++++++++
 2 files changed, 124 insertions(+)
 create mode 100644 src/webgpu/shader/validation/expression/call/builtin/workgroupUniformLoad.spec.ts

diff --git a/src/webgpu/listing_meta.json b/src/webgpu/listing_meta.json
index 51178e1fe54c..13b103117eba 100644
--- a/src/webgpu/listing_meta.json
+++ b/src/webgpu/listing_meta.json
@@ -1886,6 +1886,8 @@
   "webgpu:shader,validation,expression,call,builtin,unpack4xU8:must_use:*": { "subcaseMS": 32.800 },
   "webgpu:shader,validation,expression,call,builtin,unpack4xU8:supported:*": { "subcaseMS": 98.501 },
   "webgpu:shader,validation,expression,call,builtin,unpack4xU8:unsupported:*": { "subcaseMS": 346.801 },
+  "webgpu:shader,validation,expression,call,builtin,workgroupUniformLoad:only_in_compute:*": { "subcaseMS": 1.000 },
+  "webgpu:shader,validation,expression,call,builtin,workgroupUniformLoad:no_atomics:*": { "subcaseMS": 1.000 },
   "webgpu:shader,validation,extension,pointer_composite_access:deref:*": { "subcaseMS": 0.0 },
   "webgpu:shader,validation,extension,pointer_composite_access:pointer:*": { "subcaseMS": 0.0 },
   "webgpu:shader,validation,functions,alias_analysis:aliasing_inside_function:*": { "subcaseMS": 1.200 },
diff --git a/src/webgpu/shader/validation/expression/call/builtin/workgroupUniformLoad.spec.ts b/src/webgpu/shader/validation/expression/call/builtin/workgroupUniformLoad.spec.ts
new file mode 100644
index 000000000000..ac7fd042eb5d
--- /dev/null
+++ b/src/webgpu/shader/validation/expression/call/builtin/workgroupUniformLoad.spec.ts
@@ -0,0 +1,122 @@
+export const description = `
+Validation tests for the workgroupUniformLoad() builtin.
+`;
+
+import { makeTestGroup } from '../../../../../../common/framework/test_group.js';
+import { keysOf } from '../../../../../../common/util/data_tables.js';
+import { ShaderValidationTest } from '../../../shader_validation_test.js';
+
+export const g = makeTestGroup(ShaderValidationTest);
+
+const kEntryPoints = {
+  none: { supportsBarrier: true, code: `` },
+  compute: {
+    supportsBarrier: true,
+    code: `@compute @workgroup_size(1)
+fn main() {
+  foo();
+}`,
+  },
+  vertex: {
+    supportsBarrier: false,
+    code: `@vertex
+fn main() -> @builtin(position) vec4f {
+  foo();
+  return vec4f();
+}`,
+  },
+  fragment: {
+    supportsBarrier: false,
+    code: `@fragment
+fn main() {
+  foo();
+}`,
+  },
+  compute_and_fragment: {
+    supportsBarrier: false,
+    code: `@compute @workgroup_size(1)
+fn main1() {
+  foo();
+}
+
+@fragment
+fn main2() {
+  foo();
+}
+`,
+  },
+  fragment_without_call: {
+    supportsBarrier: true,
+    code: `@fragment
+fn main() {
+}
+`,
+  },
+};
+
+g.test('only_in_compute')
+  .specURL('https://www.w3.org/TR/WGSL/#sync-builtin-functions')
+  .desc(
+    `
+Synchronization functions must only be used in the compute shader stage.
+`
+  )
+  .params(u =>
+    u
+      .combine('entry_point', keysOf(kEntryPoints))
+      .combine('call', ['bar()', 'workgroupUniformLoad(&wgvar)'])
+  )
+  .fn(t => {
+    const config = kEntryPoints[t.params.entry_point];
+    const code = `
+${config.code}
+
+var<workgroup> wgvar : u32;
+
+fn bar() -> u32 {
+  return 0;
+}
+
+fn foo() {
+  _ = ${t.params.call};
+}`;
+    t.expectCompileResult(t.params.call === 'bar()' || config.supportsBarrier, code);
+  });
+
+// A list of types that contains atomics, with a single control case.
+const kAtomicTypes: string[] = [
+  'bool', // control case
+  'atomic<i32>',
+  'atomic<u32>',
+  'array<atomic<i32>, 4>',
+  'AtomicStruct',
+];
+
+g.test('no_atomics')
+  .desc(
+    `
+The argument passed to workgroupUniformLoad cannot contain any atomic types.
+
+NOTE: Various other valid types are tested via execution tests, so we only check for invalid types here.
+`
+  )
+  .params(u =>
+    u.combine('type', kAtomicTypes).combine('call', ['bar()', 'workgroupUniformLoad(&wgvar)'])
+  )
+  .fn(t => {
+    const code = `
+struct AtomicStruct {
+  a : atomic<u32>
+}
+
+var<workgroup> wgvar : ${t.params.type};
+
+fn bar() -> bool {
+  return true;
+}
+
+fn foo() {
+  _ = ${t.params.call};
+}`;
+    t.expectCompileResult(t.params.type === 'bool' || t.params.call === 'bar()', code);
+  });